Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.ipdb: 0.8.1 -> 0.12 #58965

Merged
merged 1 commit into from Apr 8, 2019

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Apr 4, 2019

Motivation for this change

In response to 2750333#r33018563
upgrading ipdb version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc
Copy link
Member Author

costrouc commented Apr 4, 2019

@GrahamcOfBorg build python2Packages.ipdb python3Packages.ipdb

@dotlambda
Copy link
Member

test_import (tests.test_import.ImportTest) ... /nix/store/c0pcvlcr21fiw051f9cna7cnq49jwz8l-python2.7-ipython-5.8.0/lib/python2.7/site-packages/IPython/paths.py:69: UserWarning: IPython parent '/homeless-shelter' is not a writable location, using a temp directory.

Maybe we should add

preCheck = ''
  export HOME=$(mktemp -d)
'';

@costrouc
Copy link
Member Author

costrouc commented Apr 4, 2019

I will make this change later today.

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotlambda's request (just marking this as changes requested)

@gotcha
Copy link
Contributor

gotcha commented Apr 6, 2019

@costrouc Thanks for the pull request.

@costrouc
Copy link
Member Author

costrouc commented Apr 8, 2019

@GrahamcOfBorg build python2Packages.ipdb python3Packages.ipdb

@costrouc
Copy link
Member Author

costrouc commented Apr 8, 2019

Changes made. Ready for merge

@timokau timokau merged commit 7bb8ef3 into NixOS:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants