Chili sddm theme #59016

feijoas · 2019-04-05T14:53:57Z

Motivation for this change

Added the chili login theme for SDDM: https://github.com/MarianArlt/sddm-chili

Chili is hot, just like a real chili! Spice up the login experience for your users, your family and yourself. Chili reduces all the clutter and leaves you with a clean, easy to use, login interface with a modern yet classy touch.

Things done

nixos-discourse · 2019-04-05T15:08:03Z

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/sddm-theme-location-in-nixpkgs/2604/3

michaelpj · 2019-04-05T16:04:08Z

pkgs/misc/themes/sddm/chili/default.nix

+    sha256 = "036fxsa7m8ymmp3p40z671z163y6fcsa9a641lrxdrw225ssq5f3";
+  };
+
+  buildInputs = [ qtbase qtquickcontrols qtgraphicaleffects ];


These don't actually seem to do anything - afaict there is no build for this derivation?

Yes, just an unzip. What is the recommended phase to add the qt deps?

Well, where are they needed? Presumably sddm uses them when it loads the theme. If this works (which I guess it does if you tested it?) then presumably sddm already has the dependencies around when it loads it. In which case you can delete these.

I tested it. Without this line it does not work. I guess some qt path are set automatically.

Hm indeed, somehow something is putting them in propagated build inputs. I always find that a bit magical, but it seems to work.

michaelpj · 2019-04-05T16:05:34Z

pkgs/misc/themes/sddm/chili/default.nix

+/*
+  This derivation installs the chili theme. Use
+    `services.xserverdisplayManager.sddm.theme = "chili";`
+  to enable the theme.


You also need to install the package.

I don't think it's that useful to put installation instructions in comments in the .nix files. Probably the right place would be a section on sddm in the manual, or an extension to the module option doc for the sddm.theme option.

TBH it would probably be better to teach the sddm module a themePackages option rather than relying on installing it system-wide, but that's another kettle of fish.

Certainly. There is an example for lightdm greeters in nixpkgs.

c0bw3b · 2019-04-21T17:17:24Z

IMHO it should rather be placed under pkgs/data/themes/
(less random than top-level 'misc')

c0bw3b · 2019-04-21T17:18:27Z

pkgs/top-level/all-packages.nix

@@ -147,6 +147,8 @@ in

  castxml = callPackage ../development/tools/castxml { };

+  chili-sddm-theme = libsForQt5.callPackage ../misc/themes/sddm/chili {};


It should be further down in the ### DATA section

romildo · 2019-04-21T18:45:06Z

IMHO it should rather be placed under pkgs/misc/themes/
(less random than than top-level 'misc')

More recently themes are being put at pkgs/data/themes.

c0bw3b · 2019-04-21T20:00:48Z

More recently themes are being put at pkgs/data/themes.

Oops, that's what I wanted to point out in the first place but then I pasted the wrong path...
I edited, thanks. 🐱

stale · 2020-06-01T03:24:16Z

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the
related code and @ mention them in a comment.
Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
irc.freenode.net.

rileyinman · 2020-06-10T16:08:39Z

I would still be interested in seeing this happen. I just found out about it, but I used to use chili as well.

nixos-discourse · 2020-10-31T23:57:45Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/353

Vonfry · 2020-11-01T01:57:55Z

pkgs/top-level/all-packages.nix

@@ -17207,6 +17207,8 @@ in

  camingo-code = callPackage ../data/fonts/camingo-code { };

+  chili-theme = libsForQt5.callPackage ../data/themes/chili/chili.nix {};


How about use default.nix instead of chili.nix? Other files under theme dir use default.nix

SuperSandro2000 · 2020-11-25T21:52:07Z

pkgs/data/themes/chili/chili.nix

+    license = licenses.gpl3;
+    maintainers = with maintainers; [ mschneider ];
+    homepage = https://github.com/MarianArlt/sddm-chili;
+    description = "The chili login theme for SDDM";
+    longDescription = ''
+      Chili is hot, just like a real chili! Spice up the login experience for your users, your family and yourself. Chili reduces all the clutter and leaves you with a clean, easy to use, login interface with a modern yet classy touch.
+    '';


Suggested change

license = licenses.gpl3;

maintainers = with maintainers; [ mschneider ];

homepage = https://github.com/MarianArlt/sddm-chili;

description = "The chili login theme for SDDM";

longDescription = ''

Chili is hot, just like a real chili! Spice up the login experience for your users, your family and yourself. Chili reduces all the clutter and leaves you with a clean, easy to use, login interface with a modern yet classy touch.

'';

description = "The chili login theme for SDDM";

longDescription = ''

Chili is hot, just like a real chili! Spice up the login experience for your users, your family and yourself. Chili reduces all the clutter and leaves you with a clean, easy to use, login interface with a modern yet classy touch.

homepage = https://github.com/MarianArlt/sddm-chili;

license = licenses.gpl3;

maintainers = with maintainers; [ mschneider ];

'';

SuperSandro2000 · 2020-11-25T22:02:25Z

Result of nixpkgs-review pr 59016 run on x86_64-linux 1

1 package built:

chili-theme

stale · 2021-06-03T20:34:43Z

I marked this as stale due to inactivity. → More info

Mindavi · 2022-04-25T21:17:28Z

I'm gonna close this since it's bitrotted and upstream hasn't made any updates anymore either. Reading the comments this may still work fine though, so: if someone wants to pick this up, they're free to do it.

It doesn't feel like the original author is still willing to get this in, but please reopen or resubmit if so.

error: attribute 'lib' missing

       at /home/rick/.cache/nixpkgs-review/pr-59016/nixpkgs/pkgs/data/themes/chili/chili.nix:21:15:

           20|
           21|   meta = with stdenv.lib; {
             |               ^
           22|     license = licenses.gpl3;
(use '--show-trace' to show detailed location information)

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Apr 5, 2019

michaelpj reviewed Apr 5, 2019

View reviewed changes

michaelpj approved these changes Apr 8, 2019

View reviewed changes

c0bw3b reviewed Apr 21, 2019

View reviewed changes

This was referenced Oct 5, 2019

sddm: add a themePackages module option so themes are not installed globally #70494

Closed

plasma-chili: init at 0.5.5 #70495

Closed

feijoas force-pushed the chili-sddm-theme branch from e09959c to 8fc2453 Compare November 27, 2019 17:34

chili-sddm-theme: init at 0.1.5

7769856

feijoas force-pushed the chili-sddm-theme branch from 8fc2453 to 7769856 Compare November 27, 2019 17:37

stale bot added the 2.status: stale label Jun 1, 2020

stale bot removed the 2.status: stale label Jun 10, 2020

Vonfry reviewed Nov 1, 2020

View reviewed changes

SuperSandro2000 requested changes Nov 25, 2020

View reviewed changes

stale bot added the 2.status: stale label Jun 3, 2021

stale bot removed the 2.status: stale label Jan 8, 2022

Artturin added the 12.approvals: 1 label Apr 13, 2022

Mindavi closed this Apr 25, 2022

sents mentioned this pull request Apr 2, 2023

Add Chili sddm theme #224352

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chili sddm theme #59016

Chili sddm theme #59016

feijoas commented Apr 5, 2019

nixos-discourse commented Apr 5, 2019

michaelpj Apr 5, 2019

feijoas Apr 5, 2019

michaelpj Apr 5, 2019

feijoas Apr 6, 2019

michaelpj Apr 8, 2019

michaelpj Apr 5, 2019

michaelpj Apr 5, 2019

feijoas Apr 5, 2019

c0bw3b commented Apr 21, 2019 •

edited

Loading

c0bw3b Apr 21, 2019

romildo commented Apr 21, 2019

c0bw3b commented Apr 21, 2019

stale bot commented Jun 1, 2020

rileyinman commented Jun 10, 2020

nixos-discourse commented Oct 31, 2020

Vonfry Nov 1, 2020

SuperSandro2000 Nov 25, 2020

SuperSandro2000 commented Nov 25, 2020

stale bot commented Jun 3, 2021

Mindavi commented Apr 25, 2022

		@@ -147,6 +147,8 @@ in

		castxml = callPackage ../development/tools/castxml { };

		chili-sddm-theme = libsForQt5.callPackage ../misc/themes/sddm/chili {};

		@@ -17207,6 +17207,8 @@ in

		camingo-code = callPackage ../data/fonts/camingo-code { };

		chili-theme = libsForQt5.callPackage ../data/themes/chili/chili.nix {};

Chili sddm theme #59016

Chili sddm theme #59016

Conversation

feijoas commented Apr 5, 2019

Motivation for this change

Things done

nixos-discourse commented Apr 5, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

c0bw3b commented Apr 21, 2019 • edited Loading

Choose a reason for hiding this comment

romildo commented Apr 21, 2019

c0bw3b commented Apr 21, 2019

stale bot commented Jun 1, 2020

rileyinman commented Jun 10, 2020

nixos-discourse commented Oct 31, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SuperSandro2000 commented Nov 25, 2020

stale bot commented Jun 3, 2021

Mindavi commented Apr 25, 2022

c0bw3b commented Apr 21, 2019 •

edited

Loading