Enhancement for code readability

- no more useless comment (fix #4)
tigerwill90 · Jan 27, 2018 · e2f6874 · e2f6874
1 parent e763a52
commit e2f6874
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 85 deletions.
diff --git a/out/artifacts/library/library.war b/out/artifacts/library/library.war
diff --git a/src/ch/sylvainmuller/controller/BookController.java b/src/ch/sylvainmuller/controller/BookController.java
@@ -17,33 +17,22 @@
 @WebServlet(urlPatterns = "/books")
 public class BookController extends HttpServlet {
 
-    /** Universal version identifier for Serializable class */
     private static final long serialVersionUID = 1L;
 
     @EJB
     private BookService bookService;
 
-    /**
-     * Fetch books list in DB and display it
-     * @param request
-     * @param response
-     * @throws ServletException
-     * @throws IOException
-     */
     @Override
     protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
 
-        /** Get id of item to delete */
         String param = request.getParameter("id");
         if (param != null && !param.isEmpty()) {
             int id = Integer.parseInt(param);
             bookService.deleteBook(id);
         }
 
-        /** Get books collection */
         List<Book> books = bookService.getBooks();
 
-        /** Set attribute and forward */
         request.setAttribute("books", books);
         request.getRequestDispatcher(WEBINF_PATH + "/book.jsp").forward(request, response);
     }

diff --git a/src/ch/sylvainmuller/controller/LoginController.java b/src/ch/sylvainmuller/controller/LoginController.java
@@ -12,7 +12,6 @@
 @WebServlet(urlPatterns = "/login")
 public class LoginController extends HttpServlet {
 
-    /** Universal version identifier for Serializable class */
     private static final long serialVersionUID = 1L;
 
     @Override

diff --git a/src/ch/sylvainmuller/controller/LogoutController.java b/src/ch/sylvainmuller/controller/LogoutController.java
@@ -13,7 +13,6 @@
 @WebServlet(urlPatterns = "/logout")
 public class LogoutController extends HttpServlet {
 
-    /** Universal version identifier for Serializable class */
     private static final long serialVersionUID = 1L;
 
     @Override

diff --git a/src/ch/sylvainmuller/models/Book.java b/src/ch/sylvainmuller/models/Book.java
@@ -5,13 +5,9 @@
 import java.io.Serializable;
 import java.util.Date;
 
-import static javax.persistence.GenerationType.IDENTITY;
-
 @Entity
-//@Table(name="Book")
 public class Book implements Serializable {
 
-    /** Universal version identifier for Serializable class */
     private static final long serialVersionUID = 1L;
 
     @Id
@@ -26,12 +22,6 @@ public class Book implements Serializable {
 
     private Date year;
 
-    /**
-     * @param title
-     * @param author
-     * @param editor
-     * @param year
-     */
     public Book(String title, String author, String editor, Date year) {
         this.title = title;
         this.author = author;
@@ -55,82 +45,42 @@ public Book(String title, String author, String editor) {
 
     public Book() {}
 
-    /**
-     * Get id
-     * @return
-     */
     public Long getId() {
         return id;
     }
 
-    /**
-     * Set id
-     * @param id
-     */
     public void setId(Long id) {
         this.id = id;
     }
 
-    /**
-     * Get title
-     * @return
-     */
     public String getTitle() {
         return title;
     }
 
-    /**
-     * Set title
-     * @param title
-     */
     public void setTitle(String title) {
         this.title = title;
     }
 
-    /**
-     * Get author
-     * @return
-     */
     public String getAuthor() {
         return author;
     }
 
-    /**
-     * Set author
-     * @param author
-     */
     public void setAuthor(String author) {
         this.author = author;
     }
 
-    /**
-     * Get editor
-     * @return
-     */
     public String getEditor() {
         return editor;
     }
 
-    /**
-     * Set editor
-     * @param editor
-     */
     public void setEditor(String editor) {
         this.editor = editor;
     }
 
-    /**
-     * Get year
-     * @return
-     */
     public Date getYear() {
         return year;
     }
 
-    /**
-     * Set year
-     * @param year
-     */
     public void setYear(Date year) {
         this.year = year;
     }

diff --git a/src/ch/sylvainmuller/services/BookService.java b/src/ch/sylvainmuller/services/BookService.java
@@ -14,47 +14,25 @@ public class BookService {
     @PersistenceContext(unitName="books-unit")
     private EntityManager em;
 
-    /**
-     * Get a list of books
-     * @return
-     */
     public List<Book> getBooks() {
         return em.createQuery("SELECT b FROM Book AS b").getResultList();
     }
 
-    /**
-     * Create a new book
-     * @param book
-     * @return
-     */
     public void newBooks(Book book) {
         em.persist(book);
     }
 
-    /**
-     * Delete a book
-     * @param id
-     */
     public void deleteBook(int id) {
         Book book = findBook(id);
         if (book != null) {
             em.remove(book);
         }
     }
 
-    /**
-     * Find a book
-     * @param id
-     * @return
-     */
     public Book findBook(int id) {
         return em.find(Book.class, id);
     }
 
-    /**
-     * Update a book
-     * @param book
-     */
     public void updateBook(Book book) {
         em.merge(book);
     }