Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos aws: use in-kernel ixgbevf driver #58956

Merged
merged 1 commit into from Aug 14, 2019
Merged

Conversation

peterhoeg
Copy link
Member

Motivation for this change

The ixgbevf driver is supposed to give better performance on AWS.

We currently carry version 4.3.4 which is broken with kernels >= 4.19.

The latest available version 4.5.2 works with kernels <= 4.20 but is broken with >= 5.0.

However, ixgbevf is already part of the upstream kernel and we build it as a module in the default config on NixOS so there really is no reason (AFAIK) to prefer the out-of-tree driver.

We don't have any instances running that use this driver as they all use ena so I don't have a way to properly test things. What I have tested is that it is now possible to run the latest kernel on AWS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danbst
Copy link
Contributor

danbst commented Aug 14, 2019

I've launched a C3 with

[root@ip-10-0-30-193:~]# cat /etc/nixos/configuration.nix
{ config, lib, ... }: {
  imports = [ <nixpkgs/nixos/modules/virtualisation/amazon-image.nix> ];
  ec2.hvm = true;
  boot.extraModulePackages = lib.mkForce [ config.boot.kernelPackages.ena ];
}

and seems like it works:

[root@ip-10-0-30-193:~]# ethtool -i eth0
driver: ixgbevf
version: 4.1.0-k
firmware-version:
expansion-rom-version:
bus-info: 0000:00:03.0
supports-statistics: yes
supports-test: yes
supports-eeprom-access: no
supports-register-dump: yes
supports-priv-flags: yes

@danbst danbst merged commit 503ca1f into NixOS:master Aug 14, 2019
@peterhoeg peterhoeg deleted the f/ixgbevf branch August 15, 2019 09:57
@peterhoeg peterhoeg restored the f/ixgbevf branch August 15, 2019 11:13
@peterhoeg peterhoeg deleted the f/ixgbevf branch September 2, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants