nixos aws: use in-kernel ixgbevf driver #58956
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The
ixgbevf
driver is supposed to give better performance on AWS.We currently carry version 4.3.4 which is broken with kernels >= 4.19.
The latest available version 4.5.2 works with kernels <= 4.20 but is broken with >= 5.0.
However, ixgbevf is already part of the upstream kernel and we build it as a module in the default config on NixOS so there really is no reason (AFAIK) to prefer the out-of-tree driver.
We don't have any instances running that use this driver as they all use
ena
so I don't have a way to properly test things. What I have tested is that it is now possible to run the latest kernel on AWS.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)