Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: 0.90.2 -> 0.91.1 #58954

Merged
merged 4 commits into from Apr 5, 2019
Merged

home-assistant: 0.90.2 -> 0.91.1 #58954

merged 4 commits into from Apr 5, 2019

Conversation

dotlambda
Copy link
Member

Motivation for this change

https://www.home-assistant.io/blog/2019/04/03/release-91/

Even though they "finished the great migration", I'd like to keep both ways of computing the components used from the config around in case someone uses an older Home Assistant version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh as a code owner April 4, 2019 07:16
@peterhoeg
Copy link
Member

I'd like to keep both ways of computing the components used from the config around in case someone uses an older Home Assistant version.

👍

I'm going to give this a go on the weekend - would love to be able to drop ZoneMinder.

@dotlambda dotlambda changed the title home-assistant: 0.90.2 -> 0.91.0 home-assistant: 0.90.2 -> 0.91.1 Apr 5, 2019
@globin globin merged commit 38b4d2c into NixOS:master Apr 5, 2019
@dotlambda
Copy link
Member Author

@globin We should have waited for @peterhoeg's approval.

@dotlambda dotlambda deleted the home-assistant-0.91 branch April 5, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dotlambda @peterhoeg @globin @infinisil @GrahamcOfBorg