Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.03] deepin updates (#58634) #58988

Merged
merged 31 commits into from Apr 7, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Backport: #58634

These deepin packages are broken on 19.03
That's because deepin.qt5dxcb-plugin failed to build.

However these were really out of date, and I don't consider that something
I'd want to have in 19.03

Notes

There were some differences that needed correction and a few conflicts.
But I've resolved them.

This change introduces the following packages:

This change omits the following commits from the original pr:

That's because they're unneeded additions for 19.03.

Things done

I've ran nix-review locally.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

(cherry picked from commit 4d5a4a6)
(cherry picked from commit 56488c9)
(cherry picked from commit 5c38dbd)
(cherry picked from commit 8532ff4)
(cherry picked from commit 2512540)
(cherry picked from commit 62b5734)
(cherry picked from commit 4846803)
Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lheckemann
Copy link
Member

lheckemann commented Apr 7, 2019

@GrahamcOfBorg build deepin.deepin-terminal

@lheckemann lheckemann merged commit d6fc310 into NixOS:release-19.03 Apr 7, 2019
@worldofpeace worldofpeace deleted the deepin-backport branch April 7, 2019 21:03
@worldofpeace
Copy link
Contributor Author

Thanks @lheckemann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants