Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writeShellScriptBin: use build-time shell in check phase #58977

Merged
merged 1 commit into from Apr 4, 2019
Merged

writeShellScriptBin: use build-time shell in check phase #58977

merged 1 commit into from Apr 4, 2019

Conversation

illegalprime
Copy link
Member

@illegalprime illegalprime commented Apr 4, 2019 •
edited

Motivation for this change

#56408 was awesome (thanks @Mic92) !
Only a small thing broke my cross-NixOS build so I thought I'd send a patch.

NOTE: I'm not sure if this would actually be correct, since the shells could be different. (how would we get a build-time-runtimeShell?) Maybe skipping the check phase during cross comp is better?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer matthewbauer merged commit f718a12 into NixOS:master Apr 4, 2019
@samueldr samueldr added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 13, 2019
@samueldr
Copy link
Member

Backported.

[release-19.03 53980bc] writeShellScriptBin: use build-time shell in check phase
Date: Thu Apr 4 13:31:51 2019 -0400
1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for the fix @illegalprime I just about tracked the same issue in the 19.03 relase branch.

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@illegalprime @samueldr @matthewbauer @GrahamcOfBorg