Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrow-cpp: 0.12.0 -> 0.13.0 #59046

Merged
merged 4 commits into from Apr 27, 2019
Merged

arrow-cpp: 0.12.0 -> 0.13.0 #59046

merged 4 commits into from Apr 27, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Apr 6, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
snappy: fix include path in generated cmake target
a79fa1a
@veprbl
arrow-cpp: 0.12.0 -> 0.13.0
b99dc87 
pythonPackages.pyarrow: 0.12.0 -> 0.13.0

*_HOME variables are now gone. There are similar *_ROOT variables, but
the package discovery currently works without that.
@veprbl veprbl changed the title Pr/arrow 1 13 0 arrow-cpp: 0.12.0 -> 0.13.0 Apr 6, 2019
@veprbl
Copy link
Member Author

veprbl commented Apr 6, 2019

@GrahamcOfBorg build python2Packages.pyarrow python3Packages.pyarrow

pSub
pSub approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@pSub pSub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xeji
Copy link
Contributor

xeji commented Apr 11, 2019

aarch64 should build now
@GrahamcOfBorg build arrow-cpp python2Packages.pyarrow, python3Packages.pyarrow

@veprbl
Copy link
Member Author

veprbl commented Apr 12, 2019

@GrahamcOfBorg build python2Packages.pyarrow python3Packages.pyarrow

@veprbl
arrow-cpp: fix build on architectures other than x86_64
43c7477 
Settting ARROW_USE_SIMD=OFF used to fix i686 build for 1.12.0.
The fix for ARROW-5007 should help on aarch64.
@veprbl
Copy link
Member Author

veprbl commented Apr 15, 2019

@GrahamcOfBorg build python2Packages.pyarrow python3Packages.pyarrow

@veprbl veprbl merged commit d15be44 into NixOS:master Apr 27, 2019
@veprbl veprbl deleted the pr/arrow_1_13_0 branch December 1, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@veprbl @xeji @pSub @GrahamcOfBorg