Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncthing 1.1.0 -> 1.1.1 #59022

Merged
merged 1 commit into from Apr 7, 2019
Merged

syncthing 1.1.0 -> 1.1.1 #59022

merged 1 commit into from Apr 7, 2019

Conversation

jabranham
Copy link
Contributor

Motivation for this change

upstream release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deps.nix needs updating as well since go.mod was updated recently:
syncthing/syncthing@73fa7a6

@jabranham
Copy link
Contributor Author

@xeji thanks for the review. I re-ran vgo2nix and updated deps.nix.

Shouldn't nix-build -A syncthing have failed for me though? I wonder why it didn't.

@xeji
Copy link
Contributor

xeji commented Apr 7, 2019

Thank you.

Shouldn't nix-build -A syncthing have failed for me though? I wonder why it didn't.

The build succeeded because all dependencies were already listed in deps.nix.

@GrahamcOfBorg build syncthing

@xeji xeji merged commit 33755a7 into NixOS:master Apr 7, 2019
@jabranham jabranham deleted the syncthing branch April 7, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants