Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsecret: pass libgcrypt prefix to ./configure (cross compilation fix) #59060

Merged
merged 1 commit into from Apr 7, 2019
Merged

libsecret: pass libgcrypt prefix to ./configure (cross compilation fix) #59060

merged 1 commit into from Apr 7, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Apr 6, 2019

Fixes cross compilation builds not finding the libgcrypt-config binary.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth
libsecret: pass libgcrypt prefix to ./configure
2306fa6 
Fixes cross compilation builds not finding the libgcrypt-config binary.
@7c6f434c
Copy link
Member

7c6f434c commented Apr 7, 2019

Failure is an apparently-meaningful (but unrelated) libuv failure

@7c6f434c 7c6f434c merged commit 85350d8 into NixOS:staging Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @7c6f434c @GrahamcOfBorg