Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zim: 0.69.1 -> 0.70 #59058

Merged
merged 1 commit into from Apr 6, 2019
Merged

zim: 0.69.1 -> 0.70 #59058

merged 1 commit into from Apr 6, 2019

Conversation

pSub
Copy link
Member

@pSub pSub commented Apr 6, 2019 •
edited

Motivation for this change

Update to latest release. Includes port to python3 and gtk3. A full list of changes is available at
https://github.com/zim-desktop-wiki/zim-desktop-wiki/blob/master/CHANGELOG.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pSub
Copy link
Member Author

pSub commented Apr 6, 2019

@GrahamcOfBorg eval

@pSub
Copy link
Member Author

pSub commented Apr 6, 2019

@GrahamcOfBorg build zim

@pSub pSub merged commit 6bccbe6 into master Apr 6, 2019
@pSub pSub deleted the update-zim branch April 6, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pSub @GrahamcOfBorg