Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2: 3.3.0 -> 3.4.1 #59004

Merged
merged 1 commit into from Apr 9, 2019
Merged

radare2: 3.3.0 -> 3.4.1 #59004

merged 1 commit into from Apr 9, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 5, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Apr 5, 2019

@GrahamcOfBorg build radare2 radare2-cutter

@7c6f434c
Copy link
Member

7c6f434c commented Apr 5, 2019

radare2-cutter seems to want to use curl during the build (so it fails)

@risicle
Copy link
Contributor

risicle commented Apr 8, 2019 •
edited

I'm having the same result (but for radare2, not cutter) - wanting to download capstone-4.0.1.tar.gz, which it already has. Possibly the removal of the "curl nop" in postPatch was a bit over-optimistic.

@Mic92
Copy link
Member Author

Mic92 commented Apr 9, 2019

@GrahamcOfBorg build radare2

@Mic92
Copy link
Member Author

Mic92 commented Apr 9, 2019

@GrahamcOfBorg build radare2-cutter

@7c6f434c 7c6f434c merged commit 5d49fc7 into NixOS:master Apr 9, 2019
@Mic92 Mic92 deleted the radare2 branch April 9, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @7c6f434c @risicle @GrahamcOfBorg