Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjpeg: 2.3.0 -> 2.3.1 #59080

Merged
merged 1 commit into from Apr 16, 2019
Merged

openjpeg: 2.3.0 -> 2.3.1 #59080

merged 1 commit into from Apr 16, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 6, 2019

bug fixes, security fixes*

I /think/ we had patches for the mentioned CVE's,
but another pair of eyes is appreciated.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
openjpeg: 2.3.0 -> 2.3.1
8d5a048 
bug fixes, security fixes*

I /think/ we had patches for the mentioned CVE's,
but another pair of eyes is appreciated.
pSub
pSub reviewed Apr 6, 2019
View reviewed changes
Copy link
Member

@pSub pSub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be merged into staging instead of master?

@FRidh FRidh changed the base branch from master to staging April 16, 2019 16:55
@FRidh FRidh merged commit 07540c0 into NixOS:staging Apr 16, 2019
@Ekleog
Copy link
Member

Ekleog commented Jul 1, 2019 •
edited

Looks like there was no patch for CVE-2018-14423 already present on 19.03. Cherry-picked as d156779 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub left review comments

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtzWill @Ekleog @pSub @matthiasbeyer @FRidh @GrahamcOfBorg