Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tilingnome: init at 2019-01-18 #58980

Merged
merged 1 commit into from Apr 5, 2019
Merged

tilingnome: init at 2019-01-18 #58980

merged 1 commit into from Apr 5, 2019

Conversation

benley
Copy link
Member

@benley benley commented Apr 4, 2019

Motivation for this change

What if Gnome had a tiling window manager? This is that thing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@benley benley force-pushed the benley/tilingnome branch 2 times, most recently from 578996a to e5a8582 Compare April 4, 2019 18:22
@worldofpeace
Copy link
Contributor

Slight problem with this is that it doesn't support gnome-shell 3.32 https://github.com/rliang/gnome-shell-extension-tilingnome/blob/master/metadata.json#L5

That'll be on master any day now. Lots of changes so it might be broken.

@benley
Copy link
Member Author

benley commented Apr 4, 2019

Slight problem with this is that it doesn't support gnome-shell 3.32 https://github.com/rliang/gnome-shell-extension-tilingnome/blob/master/metadata.json#L5

That'll be on master any day now. Lots of changes so it might be broken.

Hmm, that's awkward. Tilingnome does seem to be pretty actively maintained, so I do expect it will be updated for gnome 3.32 relatively quickly.

@worldofpeace
Copy link
Contributor

An idea: you can merge this to 19.03 where gnome 3.30 will be forever, and just have on master as broken = true; until it gets fixed.

@benley
Copy link
Member Author

benley commented Apr 4, 2019

ha, that's not a bad idea. Maybe I can merge to master, cherrypick to 19.03, and mark this as broken=true on master when gnome 3.32 lands?

@worldofpeace
Copy link
Contributor

ha, that's not a bad idea. Maybe I can merge to master, cherrypick to 19.03, and mark this as broken=true on master when gnome 3.32 lands?

Sounds good.

But the marking it a broken when it lands part might be extra work.
#57027 (comment) will probably be merged as soon as the git trivialities are resolved

@jtojnar
Copy link
Contributor

jtojnar commented Apr 5, 2019

Maybe something like meta.broken = lib.versionAtLeast gnome3.gnome-shell "3.31"

@jtojnar jtojnar added this to In Progress in GNOME Apr 5, 2019
@benley
Copy link
Member Author

benley commented Apr 5, 2019

Maybe something like meta.broken = lib.versionAtLeast gnome3.gnome-shell "3.31"

oooh yes, I will do that.

@benley
Copy link
Member Author

benley commented Apr 5, 2019 •
edited

Does this look good now?

worldofpeace
worldofpeace approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@benley benley merged commit b391a16 into NixOS:master Apr 5, 2019
GNOME automation moved this from In Progress to Done Apr 5, 2019
@benley benley deleted the benley/tilingnome branch April 5, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeokondrak tadeokondrak tadeokondrak left review comments

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
GNOME
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@benley @worldofpeace @jtojnar @tadeokondrak @GrahamcOfBorg