Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tox-node: init at 0.0.7 #59055

Merged
merged 2 commits into from Apr 9, 2019
Merged

tox-node: init at 0.0.7 #59055

merged 2 commits into from Apr 9, 2019

Conversation

suhr
Copy link
Contributor

@suhr suhr commented Apr 6, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@suhr suhr changed the title tox-node: init tox-node: init at 0.0.7 Apr 6, 2019
@suhr
Copy link
Contributor Author

suhr commented Apr 7, 2019

cast @peterhoeg

matthiasbeyer
matthiasbeyer requested changes Apr 7, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split your patch into two commits:

  1. Adding yourself as maintainer
  2. Adding the package

@suhr
Copy link
Contributor Author

suhr commented Apr 7, 2019

Done. Tell if I have to change the commit message to something else.

@matthiasbeyer
Copy link
Contributor

@GrahamcOfBorg build tox-node

@suhr
Copy link
Contributor Author

suhr commented Apr 9, 2019

r?

matthiasbeyer
matthiasbeyer approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds for me.

@Ma27 Ma27 merged commit 7068925 into NixOS:master Apr 9, 2019
@Ma27
Copy link
Member

Ma27 commented Apr 9, 2019

@suhr thanks!

@suhr suhr deleted the tox-node branch April 9, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@suhr @matthiasbeyer @Ma27 @GrahamcOfBorg