Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jemalloc: 5.1.0 -> 5.2.0 #59031

Closed
wants to merge 1 commit into from
Closed

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 5, 2019

Motivation for this change

https://github.com/jemalloc/jemalloc/releases/tag/5.2.0

Tests still segfault w/musl :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review shows that this breaks mariadb

@timokau
Copy link
Member

timokau commented Apr 7, 2019

More specifics:

https://github.com/NixOS/nixpkgs/pull/59031
3 package are marked as broken and were skipped:
firefox-esr-52-unwrapped firefoxPackages.firefox-esr-52 firefoxPackages.icecat-52

52 package failed to build:
akonadi akregator chatzilla conkeror-unwrapped firefox-esr-60-unwrapped xulrunner icecat-unwrapped icedtea_web kaddressbook kdeApplications.akonadi-calendar kdeApplications.akonadi-contacts kdeApplications.akonadi-import-wizard kdeApplications.akonadi-mime kdeApplications.akonadi-notes kdeApplications.akonadi-search kdeApplications.akonadiconsole kdeApplications.calendarsupport kdeApplications.eventviews kdeApplications.incidenceeditor kdeApplications.kalarm kdeApplications.kalarmcal kdeApplications.kdepim-addons kdeApplications.kdepim-apps-libs kdeApplications.kdepim-runtime kgpg kmail kdeApplications.kmail-account-wizard kdeApplications.kmailtransport kontact korganizer kdeApplications.libgravatar kdeApplications.libkdepim kdeApplications.libksieve kdeApplications.mailcommon kdeApplications.mailimporter kdeApplications.mbox-importer kdeApplications.messagelib kdeApplications.pim-data-exporter kdeApplications.pim-sieve-editor kdeApplications.pimcommon kmymoney libreoffice-fresh libreoffice-fresh-unwrapped lispPackages.cl-mysql lispPackages.dbd-mysql mysql mozplugger slimerjs snabb thunderbird zanshin zoneminder

24 package were build:
bareos blender ceph clickhouse tor-browser-unwrapped firefoxPackages.tor-browser-7-5 gnash jemalloc libceph lua51Packages.luadbi luaPackages.luadbi lua53Packages.luadbi luajitPackages.luadbi lwan maxscale neovim-qt neovim-unwrapped openvdb prosody rethinkdb rspamd rsyslog sambaFull shmig

@dtzWill
Copy link
Member Author

dtzWill commented Apr 13, 2019

Not sure how to fix, as a workaround I personally just disabled use of jemalloc in mysql, but that may not be suitable for general use. Might be worth checking again soon, presumably upstream has a fix or solution one way or the other :).

@Izorkin
Copy link
Contributor

Izorkin commented Apr 24, 2019

nix-review shows that this breaks mariadb

And if in pkgs/top-level/all-packages.nix change to
jemalloc = pkgs.jemalloc450.override ({ disableInitExecTls = true; });
Example - https://github.com/Izorkin/nur-packages/blob/master/default.nix#L11

@dtzWill
Copy link
Member Author

dtzWill commented Nov 16, 2019

(ping in case anyone wants to poke this, will otherwise try to get this wrapped up in coming days/weeks :))

@orivej orivej mentioned this pull request Feb 29, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants