Issue #123: implement turntable mouse navigation #144

dynamodan · 2016-12-29T14:37:53Z

I took a little time to implement this. It wasn't very difficult. This comes with config checkbox (disabled by default).

… config checkbox (disabled by default)

whitequark · 2016-12-29T15:20:46Z

src/solvespace.cpp

@@ -70,6 +70,8 @@ void SolveSpaceUI::Init() {
    drawBackFaces = CnfThawBool(true, "DrawBackFaces");
    // Check that contours are closed and not self-intersecting
    checkClosedContour = CnfThawBool(true, "CheckClosedContour");
+    // Use turntable mouse navigation
+    checkTurntableNav = CnfThawBool(false, "CheckTurntableNav");


"check" in "checkClosedContour" doesn't mean "checkbox", it's a part of the option name

whitequark · 2016-12-29T15:21:34Z

src/mouse.cpp

+            if(SS.checkTurntableNav) {
+                projRight = orig.projRight.RotatedAbout(Vector::From(0, 1, 0), -s*dx);
+                projUp = orig.projUp.RotatedAbout(Vector::From(orig.projRight.x, orig.projRight.y, 0), s*dy); // lock the Z to vertical
+			} else {


please use our coding style

…r coding styles

dynamodan · 2016-12-30T23:07:00Z

Ok so commit d11ba14 addresses the variable naming and the coding style (I think). I think it was the one line being more than 100 characters long, but you didn't specify. Not sure if you will like the coding style yet. :)

whitequark · 2016-12-30T23:10:16Z

@dynamodan There are more tabs in that commit...

Anyway, other than style issues I like it. Unfortunately we still have to sort out a CLA for external contributions so I can't merge it just yet, but I'm on it.

whitequark · 2017-01-03T02:30:48Z

Hm, don't you think the Y axis is not the right one? The initial sketch is on the XY plane, so if you're extruding it then the 'turntable' will not rotate parallel the extrusion vector.

dynamodan · 2017-01-09T15:43:46Z

The build failed due to some write permission in the mac part of the travis CI:
[ 72%] Built target solvespace /Applications/Xcode.app/Contents/Developer/usr/bin/make -f src/CMakeFiles/solvespace-dmg.dir/build.macd /Users/travis/build/solvespamake[2]: write error make[1]: *** [src/CMakeFiles/solvespace-dmg.dir/all] Error 1 make[1]: write error make: *** [all] Error 1 +echo 'I can'\''t believe how deep the Travis brokenness goes. Retrying...' ./.travis/build-macos.sh: line 13: echo: write error: Resource temporarily un The command "if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then ./.travis/build-macos.sh; fi" exited with 1. Done. Your build exited with 1. /Users/travis/build.sh: line 148: shell_session_update: command not found

Doesn't have anything to do with this pull.

dynamodan · 2017-01-09T15:46:20Z

Hm, don't you think the Y axis is not the right one?
I thought about that... One thing I realized is that when I export to triangle mesh for Blender, then the part is lying on its side. I may try to get this to match Blender's coordinate system where the Z axis is "up". Is that what you were referring to? I also noticed that by default, Y seems to be "up" in solvespace. Or maybe it's just that the default view is from the top, which makes it seem so.

Evil-Spirit · 2017-01-09T15:47:23Z

@dynamodan, just use the z axis for upvector like all the normal guys.

…ation, instead of Y.

…ward Y

dynamodan · 2017-01-17T04:05:37Z

@Evil-Spirit I tried to make Z (the blue axis) be vertical, but it causes some strange bugs. By default, Y is vertical, I'm sure of it, because of the way the horizontal and vertical constraints are messed up in some work planes when Z is "up". So... Y is up for now.

whitequark · 2017-01-17T04:07:02Z

@dynamodan Horizontal and vertical constraints have nothing to do with XYZ (i.e. the global coordinate system). They are defined in reference to the workplane they're in.

Evil-Spirit · 2017-01-17T04:15:48Z

@whitequark, I can try to fix this for Z axis

dynamodan · 2017-01-17T12:53:31Z

Here's a screenshot of what I mean by the constraints being messed up. They aren't really -- the constraints still work perfectly to constrain the lines straight. The sketching is being done in the ZX workplane, with Z pointing "up", that is, toward the top of the screen.

whitequark · 2017-01-17T12:53:41Z

Yeah, that only affects the text orientation.

dynamodan · 2017-01-17T13:00:59Z

Well, not just the H and V lying on their sides, but the H is on the vertical segment, and the V is on the horizontal segment. It really confused me the other day, LOL! Anyway, in the context of turntable mouse navigation, I'm happy.

whitequark · 2017-01-17T13:02:07Z

@dynamodan Actually, now that I look closer, there's no issue. Try pressing F2 (without any turntable mode enabled). You'll see that horizontal will become what you expect from the constraints.

dynamodan · 2017-01-17T14:43:33Z

I've discovered a new bug in my turntable nav implementation. When the view is aligned to a workplane that tilts the locked axis to horizontal (i.e. parallel to my desk surface), the view becomes locked to middlebutton+drag mouse navigation. (Other movements still work, such as ctrl+middlebutton+drag and shift+middlebutton+drag.)

So in regard to this pull request, don't pull and merge just yet.

…rkplane

dynamodan · 2017-02-17T22:06:44Z

This is done now -- I've fixed the issue of Z not staying vertical when some workplanes are active. Also, over the last few weeks I've been periodically pulling and merging from the master branch and testing to keep my fork fresh so whenever you're ready it should be good to pull.

whitequark · 2017-02-19T01:42:17Z

@dynamodan OK. I'll take a look soon. We unfortunately still don't have a CLA so I can't merge yet.

whitequark · 2017-08-21T15:24:02Z

We have a CLA now so hopefully this will be merged soon!

dynamodan · 2017-11-03T01:50:21Z

That's good news! Did you do the merge yet? I just tonight merged from the latest (16540b1 at this moment) commit and successfully built in my fork. I try to do this periodically.

whitequark · 2017-11-03T02:21:33Z

Still waiting on CLA stuff...

whitequark · 2018-07-12T19:05:40Z

Thank you for your contribution, and welcome. The SolveSpace project has a Contributor License Agreement; in order for me to be able to merge your pull request, please sign it at https://cla-assistant.io/solvespace/solvespace. It will take only a small amount of your time.

dynamodan · 2018-07-12T21:14:08Z

I signed the CLA. I'll pull the latest and get my branch up to date, seems like that will make it easier to pull the turntable stuff.

whitequark · 2018-07-12T21:54:48Z

src/confscreen.cpp

+        );
+    }
+
+    InvalidateGraphics(); // not sure if this is needed after the AnimateOnto, but hey


Nope, AnimateOnto implies InvalidateGraphics.

whitequark

It looks like you have some extra changes in extlib/libdxfrw, can you exclude these? Also, it would be great if you could squash and rebase your commits so that it's just a single commit on top of master, but if you can't figure that out, I can do it myself as well.

dynamodan · 2018-07-13T03:14:27Z

I'll try to see what changed in extlib/libdxfrw, but they weren't my changes that I know of. I believe I had simply run

git submodule update --init extlib/libdxfrw

as directed in the build instructions. Something could have changed in that submodule?

dynamodan · 2019-04-04T14:49:59Z

I excluded extlib/libdxfrw. Not sure if I did it correctly, as now the appveyor and travis builds fail.

whitequark · 2019-04-04T14:50:50Z

No, you just deleted the submodule...

dynamodan · 2019-04-04T14:56:15Z

I guess I don't understand how to do this. When I checkout your branch, the extlib/libdxfrw folder is empty. When I checkout my branch, the extlib/libdxfrw folder is empty. Same, same! But when I do git submodule update --init extlib/libdxfrw in my branch, I get error: pathspec 'extlib/libdxfrw' did not match any file(s) known to git

whitequark · 2019-04-04T15:15:35Z

Thanks! I'll take a closer look soon and merge--there isn't obviously wrong that I can see.

outdated

whitequark · 2019-05-23T15:45:48Z

Merged in master, thank you for your contribution and patience.

Issue solvespace#123: implement turntable mouse navigation along with…

f6fa135

… config checkbox (disabled by default)

whitequark suggested changes Dec 29, 2016

View reviewed changes

Issue solvespace#123: correct checkTurntableNav variable naming, mino…

d11ba14

…r coding styles

Issue solvespace#123: correct tabs to spaces per style guide

fa482fc

whitequark previously approved these changes Dec 31, 2016

View reviewed changes

whitequark force-pushed the master branch from 2f40f7c to 529e1bf Compare January 5, 2017 12:20

dynamodan added 4 commits January 9, 2017 11:35

Issue solvespace#123: make Z axis the vertical axis for turntable rot…

9ad1cbe

…ation, instead of Y.

Just merging to stay up to date with upstream.

048d5b3

Merge branch 'master' of github.com:solvespace/solvespace

bf7d844

Issue solvespace#123: fix a bug affecting horizon tilt when facing to…

fc31c31

…ward Y

Merge branch 'master' of github.com:solvespace/solvespace

f5466c5

dynamodan added 3 commits January 23, 2017 20:58

Merge branch 'master' of github.com:solvespace/solvespace

48de924

Issue solvespace#123: Keep Z pointing vertical when animating onto wo…

9d55b0b

…rkplane

Merge branch 'master' of github.com:solvespace/solvespace

5f78905

whitequark force-pushed the master branch from 656c0e0 to dea573e Compare February 17, 2017 04:14

dynamodan added 2 commits March 6, 2017 21:45

Merge branch 'master' of github.com:solvespace/solvespace

d3d3a62

Merge branch 'master' of github.com:solvespace/solvespace

2a2b5e4

Merge branch 'master' of github.com:solvespace/solvespace

2e2f9d5

whitequark force-pushed the master branch from 1ce0b3e to 49ff36f Compare July 11, 2018 02:36

whitequark force-pushed the master branch 2 times, most recently from 371f33b to fb1065d Compare July 12, 2018 20:24

Merge branch 'master' of github.com:solvespace/solvespace

4b30642

whitequark reviewed Jul 12, 2018

View reviewed changes

dynamodan added 2 commits April 4, 2019 07:42

Bring turntable changes up to date with current

17c37df

keep extlib/libdxfrw folder

5631967

libdxfrw re-added as submodule

39851ba

whitequark closed this May 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue #123: implement turntable mouse navigation #144

Issue #123: implement turntable mouse navigation #144

dynamodan commented Dec 29, 2016

whitequark Dec 29, 2016

whitequark Dec 29, 2016

dynamodan commented Dec 30, 2016

whitequark commented Dec 30, 2016

whitequark commented Jan 3, 2017

dynamodan commented Jan 9, 2017

dynamodan commented Jan 9, 2017

Evil-Spirit commented Jan 9, 2017 •

edited

dynamodan commented Jan 17, 2017

whitequark commented Jan 17, 2017

Evil-Spirit commented Jan 17, 2017

dynamodan commented Jan 17, 2017

whitequark commented Jan 17, 2017

dynamodan commented Jan 17, 2017

whitequark commented Jan 17, 2017

dynamodan commented Jan 17, 2017 •

edited

dynamodan commented Feb 17, 2017

whitequark commented Feb 19, 2017

whitequark commented Aug 21, 2017

dynamodan commented Nov 3, 2017

whitequark commented Nov 3, 2017

whitequark commented Jul 12, 2018

dynamodan commented Jul 12, 2018

whitequark Jul 12, 2018

whitequark left a comment

dynamodan commented Jul 13, 2018

dynamodan commented Apr 4, 2019

whitequark commented Apr 4, 2019

dynamodan commented Apr 4, 2019

whitequark commented Apr 4, 2019

whitequark commented May 23, 2019

Issue #123: implement turntable mouse navigation #144

Issue #123: implement turntable mouse navigation #144

Conversation

dynamodan commented Dec 29, 2016

whitequark Dec 29, 2016

Choose a reason for hiding this comment

whitequark Dec 29, 2016

Choose a reason for hiding this comment

dynamodan commented Dec 30, 2016

whitequark commented Dec 30, 2016

whitequark commented Jan 3, 2017

dynamodan commented Jan 9, 2017

dynamodan commented Jan 9, 2017

Evil-Spirit commented Jan 9, 2017 • edited

dynamodan commented Jan 17, 2017

whitequark commented Jan 17, 2017

Evil-Spirit commented Jan 17, 2017

dynamodan commented Jan 17, 2017

whitequark commented Jan 17, 2017

dynamodan commented Jan 17, 2017

whitequark commented Jan 17, 2017

dynamodan commented Jan 17, 2017 • edited

dynamodan commented Feb 17, 2017

whitequark commented Feb 19, 2017

whitequark commented Aug 21, 2017

dynamodan commented Nov 3, 2017

whitequark commented Nov 3, 2017

whitequark commented Jul 12, 2018

dynamodan commented Jul 12, 2018

whitequark Jul 12, 2018

Choose a reason for hiding this comment

whitequark left a comment

Choose a reason for hiding this comment

dynamodan commented Jul 13, 2018

dynamodan commented Apr 4, 2019

whitequark commented Apr 4, 2019

dynamodan commented Apr 4, 2019

whitequark commented Apr 4, 2019

whitequark commented May 23, 2019

Evil-Spirit commented Jan 9, 2017 •

edited

dynamodan commented Jan 17, 2017 •

edited