Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option 'Make faces selectable with mouse' doesn't stay disabled #390

Closed
philtipping opened this issue Apr 4, 2019 · 2 comments
Closed

Option 'Make faces selectable with mouse' doesn't stay disabled #390

philtipping opened this issue Apr 4, 2019 · 2 comments
Labels
question

Comments

@philtipping
Copy link

System information

SolveSpace version: 3.0~46528bfc

Operating system: lubuntu 18.04.2 LTS

Expected behavior

'Make faces selectable with mouse' option should stay disabled until user enables it.
Note this is a presumption so may not be a bug.

Actual behavior

Option enables itself when group is re-activated.

Additional information

Recreate problem as follows:-
sketch a rectangle
extrude sketch
disable the option
click home
activate previous sketch-in-plane group - option remains disabled as expected
re-activate extrude group - option becomes enabled
@whitequark
Copy link
Contributor

That's deliberate:

solvespace/src/group.cpp

Lines 351 to 360 in a7b2f28

void Group::Activate() {
if(type == Type::EXTRUDE || type == Type::LINKED || type == Type::LATHE ||
type == Type::TRANSLATE || type == Type::ROTATE) {
SS.GW.showFaces = true;
} else {
SS.GW.showFaces = false;
}
SS.MarkGroupDirty(h); // for good measure; shouldn't be needed
SS.ScheduleShowTW();
}

@philtipping
Copy link
Author

Ok, if it's intentional, that's fine.
Not sure of the github protocol so do I close this or do you?
Many thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitequark @philtipping