Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to add a nixpkgs prefix that isn't a path but a string #1123

Closed
wants to merge 1 commit into from
Closed

Allow to add a nixpkgs prefix that isn't a path but a string #1123

wants to merge 1 commit into from

Conversation

azazel75
Copy link

@azazel75 azazel75 commented Apr 4, 2019

This allows to make a release using a string for nixpkgs:

See https://discourse.nixos.org/t/what-am-i-doing-wrong-here

TL;DR as unstable and stable diverge, it's necessary to explicitly build nixops with a stable nixpkgs, with something like:

let
  # nixos-18.09-small Released on 2019-03-02
  stableTarball = builtins.fetchTarball {
    url = "https://github.com/NixOs/nixpkgs-channels/archive/80754f5cfd69d0caf8cff6795d3ce6d99479abde.tar.gz";
    sha256 = "1v8g68gqgij389dssh6ry5x1zlhpgcgwjac0rgrh8146gf9hq74f";
  };
  pkgs = import <nixpkgs> {};
  remoteVirtNixOpsPkg = /home/azazel/wip/nixos/nixops;
  nixOpsRelease = import "${remoteVirtNixOpsPkg}/release.nix" {nixpkgs=stableTarball;};
in
  nixOpsRelease.build.${pkgs.system}

this patch allows to do that now that builtins.toPath is essentially a noop

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/what-am-i-doing-wrong-here/2517/8

@dhess
Copy link
Contributor

dhess commented May 29, 2019

Can a NixOps maintainer please merge this? It's a maddening bug, and it cost me hours of frustration and confusion before I happened upon the Discourse discussion that explained what's happening.

johnalotoski added a commit to input-output-hk/nixops that referenced this pull request Jun 19, 2019
@johnalotoski
Upstream PR 1123 patch to allow custom nixpkgs build
c67a677 
Fixes a build issue caused by a toPath nop from
fetchTabar.

See: NixOS#1123
@azazel75 azazel75 mentioned this pull request Jul 17, 2019
Merged
6 tasks
@grahamc
Copy link
Member

grahamc commented Mar 26, 2020

Hello!

Thank you for this PR.

In the past several months, some major changes have taken place in
NixOps:

  1. Backends have been removed, preferring a plugin-based architecture.
    Here are some of them:

  2. NixOps Core has been updated to be Python 3 only, and at the
    same time, MyPy type hints have been added and are now strictly
    required during CI.

This is all accumulating in to what I hope will be a NixOps 2.0
release. There is a tracking issue for that:
#1242 . It is possible that
more core changes will be made to NixOps for this release, with a
focus on simplifying NixOps core and making it easier to use and work
on.

My hope is that by adding types and more thorough automated testing,
it will be easier for contributors to make improvements, and for
contributions like this one to merge in the future.

However, because of the major changes, it has become likely that this
PR cannot merge right now as it is. The backlog of now-unmergable PRs
makes it hard to see which ones are being kept up to date.

If you would like to see this merge, please bring it up to date with
master and reopen it. If the or mypy type checking fails, please
correct any issues and then reopen it. I will be looking primarily at
open PRs whose tests are all green.

Thank you again for the work you've done here, I am sorry to be
closing it now.

Graham

@grahamc grahamc closed this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@azazel75 @nixos-discourse @dhess @grahamc