Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libnotify: 0.7.7 -> 0.7.8 #59074

Merged
merged 2 commits into from Apr 30, 2019
Merged

libnotify: 0.7.7 -> 0.7.8 #59074

merged 2 commits into from Apr 30, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 6, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Apr 7, 2019

darwin failure is a regression and should be fixed before merging.

@flokli
Copy link
Contributor

flokli commented Apr 8, 2019

while switching to meson, libnotify/meson.build started setting the --version-script parameter, which doesn't exist on the MacOS linker.

We could patch it out, or upstream some sort of detection, similar to here:
mkhl/mrsh@6a31bd9#diff-969b60ad3d206fd45c208e266ccfed38R43

@jtojnar
Copy link
Contributor

jtojnar commented Apr 26, 2019

Here is an upstream MR for the Darwin failure: https://gitlab.gnome.org/GNOME/libnotify/merge_requests/9

flokli
flokli previously requested changes Apr 27, 2019
View reviewed changes
pkgs/development/libraries/libnotify/default.nix Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build libnotify

dtzWill and others added 2 commits April 30, 2019 13:59
@dtzWill @worldofpeace
libnotify: 0.7.7 -> 0.7.8
83f104a 
* cleanup a bit using new helpers
* move to meson to avoid need for gtk_doc and such
* NEWS: https://gitlab.gnome.org/GNOME/libnotify/blob/0.7.8/NEWS
* tag: https://gitlab.gnome.org/GNOME/libnotify/tags/0.7.8
@worldofpeace
libnotify: fix darwin build
f1ad53b 
Patch is upstream MR courtesy of jtojnar.
@worldofpeace worldofpeace merged commit bc757ff into NixOS:master Apr 30, 2019
@worldofpeace
Copy link
Contributor

Thanks everyone ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@flokli flokli flokli left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtzWill @xeji @flokli @jtojnar @worldofpeace @GrahamcOfBorg