Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.apcu{,_bc}: minor updates #59075

Merged
merged 2 commits into from Apr 8, 2019
Merged

phpPackages.apcu{,_bc}: minor updates #59075

merged 2 commits into from Apr 8, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 6, 2019

Motivation for this change

See linked release notes.

Was debugging php-based app and found my way to noticing these have
small updates available.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu
Copy link
Contributor

etu commented Apr 7, 2019

@GrahamcOfBorg build phpPackages.apcu phpPackages.apcu_bc

@Ma27
Copy link
Member

Ma27 commented Apr 8, 2019

Built and tested locally 👍

@etu etu merged commit 6a384a5 into NixOS:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @etu @Ma27 @GrahamcOfBorg