Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libow: init at 3.2p1 #59077

Merged
merged 2 commits into from Apr 11, 2019
Merged

libow: init at 3.2p1 #59077

merged 2 commits into from Apr 11, 2019

Conversation

divi255
Copy link
Contributor

@divi255 divi255 commented Apr 6, 2019 •
edited

Motivation for this change

libow 1-wire file system library (owfs) package

includes libraries and headers only

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@divi255 divi255 changed the title libow package (1-wire file system library) libow: init at 3.2p1 Apr 6, 2019
matthiasbeyer
matthiasbeyer requested changes Apr 7, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split your changes into two commits:

  1. Adding yourself as maintainer
  2. Adding the package

@divi255
Copy link
Contributor Author

divi255 commented Apr 7, 2019

Please split your changes into two commits:

  1. Adding yourself as maintainer
  2. Adding the package

Done

@matthiasbeyer
Copy link
Contributor

Now the commit where you add the package does not confirm to the CONTRIBUTING anymore.

Sorry for bothering you with this, but as you seem to be new I try to show you how to do it right so that people do not have to tell you later 😄

@divi255
Copy link
Contributor Author

divi255 commented Apr 7, 2019

Now the commit where you add the package does not confirm to the CONTRIBUTING anymore.

Sorry for bothering you with this, but as you seem to be new I try to show you how to do it right so that people do not have to tell you later 😄

Done )

tomberek
tomberek approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds, links, on non-NixOS, no reverse-dependencies
New maintainer.
Previously approved by @matthiasbeyer
LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/12

srhb
srhb requested changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divi255 Thank you for your contribution! I'm sorry to hold this up just a tiny bit, but I noticed that at the top of the sourceforge page, there's a note: "Project moved to https://github.com/owfs/owfs/"

SourceForge as a distribution source for this package thus appears to be deprecated. Using the new source would allow us to also utilize the fetchFromGitHub helper function to grab the newest release (v3.2p3) that is made available on GitHub as well.

@divi255
Copy link
Contributor Author

divi255 commented Apr 10, 2019 •
edited

Good day,

I see but 3.2p1 is the only production release used by other distributions (the package was actually ported from Arch, while Ubuntu is still on 3.1.x). If you want I can change source to github right now, however I suggest to keep 3.2p1 version until the new one get a positive feedback (at least for x86-64 and ARM). Unfortunately I'm not a software author (but heavy user :) and can't give any warranties about new versions.

So, let's change source to github right now or when versions newer than 3.2p1 go in production? What do you prefer?

@srhb
Copy link
Contributor

srhb commented Apr 10, 2019

@divi255 Since you're way more of an expert than me on this piece of software, I defer to your opinion. Let's go with the github source using fetchFromGitHub but keep the version. :)

@divi255
Copy link
Contributor Author

divi255 commented Apr 10, 2019

@divi255 Since you're way more of an expert than me on this piece of software, I defer to your opinion. Let's go with the github source using fetchFromGitHub but keep the version. :)

Changed to use github and fetchFromGitHub . Seems to work fine )

@srhb srhb merged commit 99eddf3 into NixOS:master Apr 11, 2019
@srhb
Copy link
Contributor

srhb commented Apr 11, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@srhb srhb srhb approved these changes

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@divi255 @matthiasbeyer @nixos-discourse @srhb @tomberek @GrahamcOfBorg @Janik-Haag