Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextcloud: fix use of mismatched php versions, updates #59078

Merged
merged 3 commits into from Apr 7, 2019
Merged

nextcloud: fix use of mismatched php versions, updates #59078

merged 3 commits into from Apr 7, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 6, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
nextcloud: use same php package throughout!
27d78f4 
`phpPackage` is 7.3 by default, but `pkgs.php` is 7.2,
so this saves the need for an extra copy of php
for the purpose of running nextcloud's cron;
more importantly this fixes problems with extensions
not loading since they are built against a different php.
@dtzWill dtzWill requested a review from infinisil as a code owner April 6, 2019 15:36
@dtzWill
nextcloud: 15.0.5 -> 15.0.6
ee22cea 
(tagged, not on nextcloud.com/changelog ?)
(admin panel bugged about the update, so should be good :))
@dtzWill
nextcloud-client: 2.5.1 -> 2.5.2
e2dbb35 
* patches applied already, per comment \o/
* use libcloudproviders, since we have it
@globin globin merged commit 0498ba6 into NixOS:master Apr 7, 2019
@Ma27
Copy link
Member

Ma27 commented Apr 7, 2019

Since the issue seems to exist on release-19.03 as well I'd suggest that we backport this. Unless anybody is faster than me, I'd do this later that night or tomorrow (currently I'm on a train with fairly poor wifi, so I can't test/backport right now).

@lheckemann
Copy link
Member

lheckemann commented Apr 8, 2019 •
edited

Thanks @Ma27, cherry-picked in fcc7097, d122dcd, 09823b5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

@Ma27 Ma27 Awaiting requested review from Ma27

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @Ma27 @lheckemann @globin @GrahamcOfBorg