Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnscrypt-proxy2: 2.0.21 -> 2.0.22 #58985

Merged
merged 2 commits into from Apr 5, 2019
Merged

dnscrypt-proxy2: 2.0.21 -> 2.0.22 #58985

merged 2 commits into from Apr 5, 2019

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Apr 4, 2019 •
edited

Motivation for this change

The previous version had issues with the .org TLD when used in conjunction with dnsmasq.

https://github.com/jedisct1/dnscrypt-proxy/releases/tag/2.0.22

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace @bbigras
Update pkgs/tools/networking/dnscrypt-proxy/2.x/default.nix
4e3b265 
Co-Authored-By: bbigras <bigras.bruno@gmail.com>
@globin globin merged commit 6ffd201 into NixOS:master Apr 5, 2019
@bbigras
Copy link
Contributor Author

bbigras commented Apr 5, 2019

Thank you very much.

@bbigras bbigras deleted the patch-1 branch April 5, 2019 15:34
@worldofpeace
Copy link
Contributor

@globin Remember to squash merge if there's commits made on github from the suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbigras @worldofpeace @globin @GrahamcOfBorg