-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R: Workaround to make which
a run-time dependency
#58989
Conversation
Workaround for issue NixOS#58963
If you wanted you could set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try adding WHICH=${which}/bin/which
into configureFlagsArray
to make R
bake the full path into its binary. That would be a much better solution.
@peti, @veprbl, but stracing R showed that R is indeed trying to access to Also, after |
@rhokue
So what happens? Does "which" get garbage collected? Or is it sandboxing? |
@veprbl I don't know... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the path to which
is correctly picked up by the build, but it doesn't appear in plaintext in any of the installed files. The problem shows up if which
gets garbage collected or not downloaded from binary cache.
Yes, @veprbl, your description matches my experience and the investigations which @cleverca22 and I made while chatting on IRC, during which we used So, it would be nice if @peti could approve this PR as well. :) |
If that path were baked into the R executable (or any of its libraries), then Nix would recognize the run-time dependency. I don't know where that store path is coming from, but it's clearly not a part of the the R binary package, or else it could not possibly be missing at run-time. |
Breaks my build.
|
Builds again after f7ddff5. |
Normally the directory is created in fixup phase.
Workaround for issue #58963.
Motivation for this change
See issue #58963.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)