pythonPackages.chevron: init at 0.13.1 #59088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldofpeace
suggested changes
Apr 7, 2019
|
I'd like to merge this before #59089 and you've added yourself to the maintainers list in both. Can you have one commit for doing that here? like: |
|
@worldofpeace thanks for taking the time to review this. Will get the changes in ASAP. |
dhl
force-pushed
the
dhl/python-modules/chevron
branch
from
cd68875
to
8185469
Compare
|
@worldofpeace I've split the commit into a maintainers and a package commit. |
|
I actually didn't see the tests being ran in the output.
Looks like we actually just need to use a particular file diff --git a/pkgs/development/python-modules/chevron/default.nix b/pkgs/development/python-modules/chevron/default.nix
index 39fb9d464d0..04de410df68 100644
--- a/pkgs/development/python-modules/chevron/default.nix
+++ b/pkgs/development/python-modules/chevron/default.nix
@@ -1,6 +1,7 @@
{ lib
, buildPythonPackage
, fetchFromGitHub
+, python
}:
buildPythonPackage rec {
@@ -15,6 +16,10 @@ buildPythonPackage rec {
sha256 = "0l1ik8dvi6bgyb3ym0w4ii9dh25nzy0x4yawf4zbcyvvcb6af470";
};
+ checkPhase = ''
+ ${python.interpreter} test_spec.py
+ '';
+
meta = with lib; {
homepage = https://github.com/noahmorrison/chevron;
description = "A python implementation of the mustache templating language";
|
|
The tests did run for me as is: |
|
They succeed for me for |
A Python implementation of mustache
dhl
force-pushed
the
dhl/python-modules/chevron
branch
from
8185469
to
7033cf0
Compare
|
Added the |
worldofpeace
approved these changes
Apr 8, 2019
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Python implementation of mustache
This is being packaged as part of the effort to update
aws-sam-clito the latest versionMotivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)