New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.aws-lambda-builders: init at 0.2.1 #59089
pythonPackages.aws-lambda-builders: init at 0.2.1 #59089
Conversation
pkgs/development/python-modules/aws-lambda-builders/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/aws-lambda-builders/default.nix
Outdated
Show resolved
Hide resolved
It's usually preferred to open one pr for that kind of purpose. Even if you don't update |
pkgs/development/python-modules/aws-lambda-builders/default.nix
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comments above.
If the package looks good to you, I'll remove the change to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at their Makefile
I think we should be running the tests like
pytest tests/functional
in the checkPhase
.
It also looks like this shouldn't be built on
else build fails for
Edit: is coming from https://github.com/awslabs/aws-lambda-builders/blob/b811288dae4598abede2c1daa54cdfd3c5865301/setup.py#L49 |
7a579e2
to
6663765
Compare
@worldofpeace I've added implemented all the suggested changes and squashed them:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds for every interpreter version ✨
A tool to compile, build and package AWS Lambda functions.
This is being packaged as part of the effort to update
aws-sam-cli
.Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)