Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.serverlessrepo: init at 0.1.8 #59072

Merged
merged 1 commit into from Apr 8, 2019
Merged

pythonPackages.serverlessrepo: init at 0.1.8 #59072

merged 1 commit into from Apr 8, 2019

Conversation

dhl
Copy link
Contributor

@dhl dhl commented Apr 6, 2019

A Python library with convenience helpers for working with the AWS Serverless Application Repository.

Packaging this in order to update aws-sam-cli to the latest version.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dhl dhl requested a review from FRidh as a code owner April 6, 2019 14:37
@worldofpeace worldofpeace mentioned this pull request Apr 8, 2019
Closed
10 tasks
@dhl
pythonPackages.serverlessrepo: init at 0.1.8
0d1ec03 
A Python library with convenience helpers for working with the AWS Serverless
Application Repository.
@dhl dhl force-pushed the pythonPackages.serverlessrepo branch from e68fbd6 to 0d1ec03 Compare April 8, 2019 08:03
@dhl
Copy link
Contributor Author

dhl commented Apr 8, 2019

All changes built and tested successfully against Python 2.7, 3.5, 3.6 and 3.7

@worldofpeace worldofpeace merged commit 0100fe9 into NixOS:master Apr 8, 2019
@worldofpeace
Copy link
Contributor

Thanks for your contributions and attentiveness @dhl ✨

In the future, if you have dependent packages for a certain feature, be sure to pr them together.
That makes things faster because they're reviewed together.

Other than that, be sure to ping me when you update aws-sam-cli.

@dhl
Copy link
Contributor Author

dhl commented Apr 8, 2019

@worldofpeace understood, and thanks for mentoring me through the process! I really appreciate the effort you've put into reviewing the PRs and getting them into shape for merging.

@dhl dhl deleted the pythonPackages.serverlessrepo branch April 8, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhl @worldofpeace @GrahamcOfBorg