Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.papis: provide as a library too #59070

Merged
merged 3 commits into from Apr 11, 2019
Merged

python3Packages.papis: provide as a library too #59070

merged 3 commits into from Apr 11, 2019

Conversation

teto
Copy link
Member

@teto teto commented Apr 6, 2019 •
edited

The project is turning into a dependency for several scripts and possibly UIs
(see the different repositories at https://github.com/papis/) so it makes sense
to have it as a library.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto teto requested a review from FRidh as a code owner April 6, 2019 14:22
@Ma27
Copy link
Member

Ma27 commented Apr 9, 2019

Shouldn't papis be built with buildPythonPackage then?

@teto
Copy link
Member Author

teto commented Apr 9, 2019

fixed it thanks

FRidh
FRidh reviewed Apr 9, 2019
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expressions of libraries belong under python-modules/

teto added 2 commits April 9, 2019 22:53
@teto
python3Packages.papis: provides as a library too
30cd235 
The project is turning into a dependency for several scripts and possibly UIs
(see the different repositories at https://github.com/papis/) so it makes sense
to have it as a library.
@teto
moved papis to python-modules
6f495d7
@teto
Copy link
Member Author

teto commented Apr 10, 2019

I was hesitant to move the files but I did it.

@dotlambda dotlambda changed the title python3Packages.papis: provides as a library too python3Packages.papis: provide as a library too Apr 10, 2019
dotlambda
dotlambda requested changes Apr 10, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add each Python dependency as an argument and you should specify disabled = !isPy3k.

pkgs/development/python-modules/papis/default.nix Outdated
@@ -2,7 +2,7 @@
, python3, xdg_utils
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, python3, xdg_utils
, xdg_utils

pkgs/development/python-modules/papis/default.nix Outdated
@@ -2,7 +2,7 @@
, python3, xdg_utils
}:

python3.pkgs.buildPythonApplication rec {
python3.pkgs.buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python3.pkgs.buildPythonPackage rec {
buildPythonPackage rec {

@teto
Copy link
Member Author

teto commented Apr 11, 2019

I've taken the review into account and added myself as maintainer. I have a good knowledge of the upcoming papis changes so I should do the next nix update.

@FRidh FRidh merged commit a4c15f1 into NixOS:master Apr 11, 2019
@teto teto deleted the papis_to_python branch April 11, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@dotlambda dotlambda dotlambda requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@teto @Ma27 @FRidh @dotlambda @GrahamcOfBorg