Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azimuth: init at 1.0.2 #59071

Merged
merged 1 commit into from May 13, 2019
Merged

azimuth: init at 1.0.2 #59071

merged 1 commit into from May 13, 2019

Conversation

marius851000
Copy link
Contributor

Motivation for this change

Wanted to play this game, so I packaged it.

Things done

I have played the game some hour without problem.
I have also quickly check the other binary.
The 3 tools have been renamed with "azimuth-" before their name to prevent conflict

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marius851000
Copy link
Contributor Author

Can someone help me to understand this error message ?

@samueldr
Copy link
Member

samueldr commented Apr 7, 2019 •
edited

Hmm, that steps works here manually, let's re-eval see if master was in a bad state transiently...

Not sure what I did wrong, it now fails as expected, might have accidentally eval'd master :).

attribute 'maintainers' missing, at /Users/samuel/tmp/nixpkgs/nixpkgs-PR59071/pkgs/games/azimuth/default.nix:60:24

The attribute isn't missing from meta; it's that stdenv.maintainers isn't it. It's stdenv.lib.maintainers.

matthiasbeyer
matthiasbeyer requested changes Apr 9, 2019
View reviewed changes
pkgs/games/azimuth/default.nix Show resolved Hide resolved
pkgs/games/azimuth/default.nix Outdated Show resolved Hide resolved
jtojnar
jtojnar requested changes Apr 9, 2019
View reviewed changes
pkgs/games/azimuth/default.nix Outdated Show resolved Hide resolved
aanderse
aanderse requested changes Apr 11, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also might want to consider filling an issue upstream asking for an install target.

pkgs/games/azimuth/default.nix Outdated Show resolved Hide resolved
aanderse
aanderse requested changes Apr 14, 2019
View reviewed changes
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
@marius851000 marius851000 mentioned this pull request Apr 29, 2019
Closed
@marius851000
Copy link
Contributor Author

@aanderse It seem to be ready

@aanderse
Copy link
Member

@marius851000 thanks for pinging me on this
@GrahamcOfBorg build azimuth

@aanderse aanderse merged commit e6c2087 into NixOS:master May 13, 2019
@aanderse
Copy link
Member

Thanks @marius851000! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer requested changes

@jtojnar jtojnar jtojnar requested changes

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@marius851000 @samueldr @aanderse @matthiasbeyer @jtojnar @GrahamcOfBorg