HylaFAX: fix ModemGroup, also minor metadata updates #59081
Conversation
|
What's the motivation behind switching from sha256 -> sha512? |
That's just a feeling in my gut that sha512 is certainly no less reliable, possibly more one day. There is not need for this change beyond. We can also drop this commit .. should we? Should I replace the pull request? |
|
Well currently the auto-update bot (@r-ryantm) at least only works for sha256, and all nix prefetching scripts output sha256 by default, so I think it might be better to keep using sha256. You don't need to replace the PR, you can just remove that commit with a |
I forgot to do this when I submitted this module with commit 12fa95f.
The manpage claims that the "limit" in the setting:: <name>:[<limit>:]<regex> is optional and defaults to zero, implying no limit. However, tests confirmed that it actually isn't optional. Without limit, the setting ``any:.*`` places outbound jobs on infinite hold if no particular modem was specified on the sendfax command line. The new default value ``any:0:.*`` from this commit uses any available modem to send jobs if not modem was given to sendfax.
* move meta attrset into curly brackets * update homepage (finally supports https) * add downloadPage * add longDescription
|
Motivation for this change
HylaFAX+ handles the ModemGroup parameter differently from the way the relevant manpage claims it is handled. This can lead to stuck jobs.
I'm using this opportunity to update/improve further minor aspects of the HylaFAX package and module.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"(no need)./result/bin/) (no need)nix path-info -Sbefore and after) (no change)At least the ModemGroup commit should be applied to release-19.03 as well. The other might be backported also as they change metadata only. Should I open a separate pull request for 19.03 ?