Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron: 4.1.3 -> 4.1.4 #59039

Merged
merged 1 commit into from Apr 7, 2019
Merged

electron: 4.1.3 -> 4.1.4 #59039

merged 1 commit into from Apr 7, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 5, 2019

https://electronjs.org/releases/stable#release-notes-for-v414

Motivation for this change

cc @ryantm -- don't suppose your wonderful update-bot could
periodically check electron? If there are technical pains preventing
this, I'm willing to see what I can do to address them, LMK! :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Apr 6, 2019

@dtzWill Unfortunately, I don't think there is much hope for my bot to handle this kind of derivation soon. It currently bails out if there are multiple fetchers in the same file. Also, I only run all my checks on x86_64, so it would be hard to check all the fetchers are working.

@xeji xeji merged commit 48ecd88 into NixOS:master Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants