(Review per top comment in PULL_REQUEST_TEMPLATE.md and doc/reviewing-contributions.xml)

Reviewed points

• package name fits guidelines (no change)
• package version fits guidelines (no change)
• package build on x86_64-linux
• executables tested on x86_64-linux (only fusermount3)
• all depending packages build: only sshfs package for testing!

Possible improvements

• I'm not sure if it might be wiser to set the path to fuse.conf with the compiler flag -DFUSE_CONF=/etc/fuser.conf.
  • It would probably be more robust than patching build system scripts (the patched file might changed in newer fuse versions).
  • It would hardcode the sysconfig path /etc in CC flags making this path harder to be changed.
  • The build system also uses -DFUSE_CONF to set this path. I tested this and using NIX_CFLAGS_COMPILE="-DFUSE_CONF=\"/etc/fuse.conf\"" prevails over the FUSE_CONF setting of fuse's build scripts, but I don't how if this precedence can be guaranteed at all times.

Comments

• Tested with nixos-unstable and nixos-19.03, with sshfs (that is based on fuse3) with the user_allow_other option in /etc/fuse.conf. It works great.
• I suggest backporting this to 19.03, maybe even 18.09 if it merges without conflicts.
• Ping fuse maintainer @primeos

@Yarny0 thank you very much for the great review :)

Regarding the possible improvement: Yes, that's a good idea but I also have some doubts that the behaviour could change in the future. Since I don't mind updating the patch if the file changes I'll merge it as it is but we/I could consider making an upstream PR to make it easier to configure (e.g. by introducing a Meson option). And thanks for the pinging me :)

Edit: @matthewbauer I've changed the commit message slightly - hope that's ok.

Backported to 19.03 in #59166. Since 19.03 should be released very soon (today?) it should be okay to skip 18.09 (feel free to make a PR and/or ping me if someone desperately needs this on 18.09 ;).