Fix #6618: Viewport vehicle draw flickering #7475
Closed
+18
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix incorrect bounds check in ViewportAddVehicles in the case where the viewport width or height is less than the hash wraparound distance, however the two bounds still map to the same hash bucket due to discarding the lower coordinate bits, such that the intermediary hash buckets are incorrectly not iterated.
LordAro
added
the
backport requested
|
How can I see the difference this makes? I've never noticed vehicles flickering. |
|
This pull request has been automatically marked as stale because it has not had any activity in the last month. |
LordAro
removed
the
backport requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect bounds check in ViewportAddVehicles in the case where the
viewport width or height is less than the hash wraparound
distance, however the two bounds still map to the same hash bucket
due to discarding the lower coordinate bits, such that the intermediary
hash buckets are incorrectly not iterated.