Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meson: don't set CC and CXX #59041

Closed
wants to merge 1 commit into from
Closed

Meson: don't set CC and CXX #59041

wants to merge 1 commit into from

Conversation

matthewbauer
Copy link
Member

These are set by the stdenv. Maybe fixes #58831.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
meson: don’t set CC and CXX in meson build
e7360f0 
These are set by the stdenv. Maybe fixes NixOS#58831.
@matthewbauer matthewbauer requested a review from shlevy April 5, 2019 21:17
@vcunat
Copy link
Member

vcunat commented Apr 5, 2019

I'm all for this, assuming it doesn't break cross-compilation, so we (someone) should test that.

@vcunat
Copy link
Member

vcunat commented Apr 8, 2019

I'm curious: why did you close this?

@matthewbauer
Copy link
Member Author

I'm curious: why did you close this?

Talking to @Ericson2314, it turns out meson treats CC and CXX as the build cc and build cxx. So it looks like that is legitimate to set it like this.

@Ericson2314
Copy link
Member

And hopefully meson fixes their behavior to match autoconf soon :)

@nh2 nh2 mentioned this pull request Feb 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlevy shlevy Awaiting requested review from shlevy

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meson overrides compiler, ignoring stdenv
4 participants
@matthewbauer @vcunat @Ericson2314 @GrahamcOfBorg