Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdns-recursor: 4.1.11 -> 4.1.12 #58982

Merged
merged 2 commits into from Apr 5, 2019
Merged

pdns-recursor: 4.1.11 -> 4.1.12 #58982

merged 2 commits into from Apr 5, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 4, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Apr 4, 2019

@GrahamcOfBorg test tests/pdns-recursor

@vcunat
Copy link
Member

vcunat commented Apr 4, 2019 •
edited

🤔 where's the security problem? (I'm mainly curious; can't see anything in NEWS.)

@vcunat
Copy link
Member

vcunat commented Apr 4, 2019

@GrahamcOfBorg test pdns-recursor

@Mic92
Copy link
Member Author

Mic92 commented Apr 4, 2019

Indeed this was actually already fixed: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-3871
Well does not hurt to update it anway.

@Mic92 Mic92 changed the title pdns-recursor: 4.1.11 -> 4.1.12 (security) pdns-recursor: 4.1.11 -> 4.1.12 Apr 4, 2019
@Mic92 Mic92 merged commit e49a143 into NixOS:master Apr 5, 2019
@Mic92 Mic92 deleted the pdns branch April 5, 2019 01:23
@vcunat
Copy link
Member

vcunat commented Apr 5, 2019

That one seems about authoritative pdns, but anyway... nothing against doing the update.

@vcunat
Copy link
Member

vcunat commented Apr 5, 2019

I wonder why the test failed on Borg, but it runs OK on my sandboxed NixOS, so I hope it will be OK on Hydra, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @vcunat @GrahamcOfBorg