pipenv: Ignore Python site-packages #59050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipenv nix wrapper contains a PYTHONPATH which has some dependencies for pipenv installed. pipenv by default uses site-packages when resolving packages, which means that any package that is included in the nix wrapper is satisfied when running `pipenv install`. But when the actual virtualenv created by pipenv is activated, it doesn't contain those packages anymore and fails to import them. pipenv has a flag PIP_IGNORE_INSTALLED which can be used to ignore site-packages. Which fixes the problem of having different resolved packages when running pipenv and when running the virtualenv.
|
cc maintainer @berdario |
FRidh
approved these changes
Apr 7, 2019
|
Please backport to 19.03, it also fixes issues there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipenv nix wrapper contains a PYTHONPATH which has some dependencies
for pipenv installed. pipenv by default uses site-packages when
resolving packages, which means that any package that is included in
the nix wrapper is satisfied when running
pipenv install.But when the actual virtualenv created by pipenv is activated, it
doesn't contain those packages anymore and fails to import them.
pipenv has a flag PIP_IGNORE_INSTALLED which can be used to ignore
site-packages. Which fixes the problem of having different resolved
packages when running pipenv and when running the virtualenv.
Motivation for this change
See issue #59049
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)