Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

environment.noXlibs: disable gnome3 support for pinentry #59051

Merged
merged 1 commit into from Apr 6, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Apr 6, 2019

Motivation for this change

environment.noXlibs already disables gtk2 and qt support when noXlibs is set -- disable gcr (gnome3) as well to avoid dragging in GTK3 and many more heavyweight dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

[x] Determined the impact on package closure size (by running nix path-info -S before and after)

cough I want to see numbers!

@delroth
Copy link
Contributor Author

delroth commented Apr 6, 2019

/nix/store/vq4848x45ci7djh5bakj5qwrh1yf2r2h-pinentry-1.1.0        284260848
/nix/store/kwba74cjc607bxwszcf3j3y9yfcbqgxw-pinentry-1.1.0         50182848

@delroth
Copy link
Contributor Author

delroth commented Apr 6, 2019

And for nixos-config = { environment.noXlibs = true; } looking at full system closure size:

/nix/store/wzsvnkqrd73w1wxk3ygphh6pna443k38-nixos-system-nixos-19.09.git.d521db7                 860.0M
/nix/store/g236lfra3j79rbgm13sxrky8i821fysi-nixos-system-nixos-19.09.git.4e0af5c                 755.0M

@timokau
Copy link
Member

timokau commented Apr 6, 2019

Very nice, thanks!

@timokau timokau merged commit f8eec8d into NixOS:master Apr 6, 2019
@delroth delroth deleted the noxlibs-gcr branch April 6, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants