Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibus: 1.5.17 -> 1.5.20 #59009

Merged
merged 1 commit into from Apr 6, 2019
Merged

ibus: 1.5.17 -> 1.5.20 #59009

merged 1 commit into from Apr 6, 2019

Conversation

aristaeus
Copy link
Contributor

@aristaeus aristaeus commented Apr 5, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 6, 2019

We should be able to remove gsettings-schema-convert.

@jtojnar jtojnar requested a review from hedning April 6, 2019 17:11
@hedning
Copy link
Contributor

hedning commented Apr 6, 2019

@GrahamcOfBorg build ibus

@hedning hedning mentioned this pull request Apr 6, 2019
Merged
28 tasks
@jtojnar jtojnar changed the base branch from master to staging April 6, 2019 22:08
@jtojnar
Copy link
Contributor

jtojnar commented Apr 6, 2019

Switching to staging, since ibus is broken there and this should fix it.

@worldofpeace worldofpeace merged commit 9df9f3c into NixOS:staging Apr 6, 2019
@aristaeus aristaeus deleted the ibus-1.5.20 branch April 7, 2019 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@lukateras lukateras Awaiting requested review from lukateras

@ttuegel ttuegel Awaiting requested review from ttuegel

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aristaeus @jtojnar @hedning @GrahamcOfBorg @worldofpeace @Janik-Haag