vdirsyncerStable: init at 0.16.7 #59010

loewenheim · 2019-04-05T11:31:19Z

Motivation for this change

Adds a package for the latest stable release of vdirsyncer.
fixes #58563

Things done

dotlambda

I'd prefer adding a stable.nix in the vdirsyncer directory.

pkgs/tools/misc/vdirsyncerStable/default.nix

dotlambda · 2019-04-05T11:42:55Z

pkgs/tools/misc/vdirsyncerStable/default.nix

+
+  checkPhase = ''
+    rm -rf vdirsyncer
+    export PYTHONPATH=$out/${python3Packages.python.sitePackages}:$PYTHONPATH


This line is probably not necessary.

Why did you just remove the entire checkPhase? Please keep the third line.

pkgs/tools/misc/vdirsyncerStable/default.nix

loewenheim · 2019-04-05T12:07:39Z

Thank you for the review. I’ll make changes as soon as I’m able.

dotlambda

Please squash your new commits into the existing one.

dotlambda · 2019-04-05T14:30:16Z

pkgs/tools/misc/vdirsyncer/stable.nix

+{ lib, python3Packages, fetchpatch }:
+
+# Packaging documentation at:
+# https://github.com/pimutils/vdirsyncer/blob/dcf5f701b7b5c21a8f4e8c80243db3e0baff1313/docs/packaging.rst


Suggested change

# https://github.com/pimutils/vdirsyncer/blob/dcf5f701b7b5c21a8f4e8c80243db3e0baff1313/docs/packaging.rst

# https://github.com/pimutils/vdirsyncer/blob/0.16.7/docs/packaging.rst

dotlambda · 2019-04-05T14:31:15Z

pkgs/tools/misc/vdirsyncer/stable.nix

+    description = "Synchronize calendars and contacts";
+    platforms = platforms.all;
+    license = licenses.mit;
+  };


According to https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes, a maintainer is required.

In that case, should I just add myself to the maintainer list?

Yes, please do so in a separate commit preceding the existing one.

dotlambda · 2019-04-05T14:31:22Z

pkgs/tools/misc/vdirsyncer/stable.nix

+  meta = with lib; {
+    homepage = https://github.com/pimutils/vdirsyncer;
+    description = "Synchronize calendars and contacts";
+    platforms = platforms.all;


Suggested change

platforms = platforms.all;

That's set automatically by buildPythonApplication.

dotlambda · 2019-04-05T14:33:29Z

pkgs/tools/misc/vdirsyncer/stable.nix

+    requests_oauthlib # required for google oauth sync
+    atomicwrites
+    milksnake
+    shippai


I can't find the last two in https://github.com/pimutils/vdirsyncer/blob/0.16.7/setup.py.

dotlambda · 2019-04-05T14:49:51Z

pkgs/tools/misc/vdirsyncer/stable.nix

+    # for setuptools_scm:
+    echo 'Version: ${version}' >PKG-INFO
+
+    sed -i 's/spec.add_external_build(cmd=cmd/spec.add_external_build(cmd="true"/g' setup.py


Most of these lines (except for the first three) should be removed.

dotlambda · 2019-04-05T14:53:40Z

@gebner @matthiasbeyer Many of my comments also apply to the vdirsyncer expression. It would be nice if you could improve it.

gebner · 2019-04-05T15:15:08Z

@dotlambda Thanks for looking over it, I've made the changes to the default vdirsyncer expression.

See #59010

gebner · 2019-04-06T17:37:09Z

pkgs/tools/misc/vdirsyncer/stable.nix

+    homepage = https://github.com/pimutils/vdirsyncer;
+    description = "Synchronize calendars and contacts";
+    license = licenses.mit;
+    maintainers = [ loewenheim ];


Suggested change

maintainers = [ loewenheim ];

maintainers = with maintainers; [ loewenheim ];

The maintainers are in lib.maintainers. This error here causes evaluation to fail, as you can see from the failing @GrahamcOfBorg check below.

Thank you. Is it possible to run the check on my machine so I can see if it works?

env VERBOSE=1 ./maintainers/scripts/eval-release.sh

vdirsyncerStable: fixed maintainers

loewenheim · 2019-04-08T07:56:58Z

Thank you again @dotlambda @gebner for your guidance.

matthiasbeyer · 2019-04-08T10:22:59Z

Awesome! Now ... may I ask what "stable" means in the context of vdirsyncer? Because I really don't see how a "0.x.y" package can be "stable".

Or, phrased in another way: How do you want to update the new "stable" package? Only from 0.16.x -> 0.16.y?

dotlambda · 2019-04-08T12:48:33Z

As you can see here, the 0.17.0 releases are still considered alpha. Hence I suggest keeping the vdirsyncerStable expression until these are considered stable, then making it an alias for vdirsyncer.

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 5, 2019

dotlambda requested changes Apr 5, 2019

View reviewed changes

dotlambda changed the title ~~vdirsyncerStable: Init at 0.16.7~~ vdirsyncerStable: init at 0.16.7 Apr 5, 2019

dotlambda requested changes Apr 5, 2019

View reviewed changes

gebner added a commit that referenced this pull request Apr 5, 2019

vdirsyncer: cleanup

b0fa0bf

See #59010

maintainers: add loewenheim

9983e35

loewenheim force-pushed the vdirsyncer-stable branch from fd6ba2a to 1df406c Compare April 6, 2019 11:49

gebner reviewed Apr 6, 2019

View reviewed changes

vdirsyncerStable: init at 0.16.7

12fb415

vdirsyncerStable: fixed maintainers

loewenheim force-pushed the vdirsyncer-stable branch from 1df406c to 12fb415 Compare April 7, 2019 10:44

GrahamcOfBorg added the 11.by: package-maintainer label Apr 7, 2019

gebner merged commit 20ff71b into NixOS:master Apr 8, 2019

loewenheim deleted the vdirsyncer-stable branch September 11, 2020 15:27

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vdirsyncerStable: init at 0.16.7 #59010

vdirsyncerStable: init at 0.16.7 #59010

loewenheim commented Apr 5, 2019 •

edited by dotlambda

Loading

dotlambda left a comment

dotlambda Apr 5, 2019

dotlambda Apr 5, 2019

loewenheim commented Apr 5, 2019

dotlambda left a comment •

edited

Loading

dotlambda Apr 5, 2019

dotlambda Apr 5, 2019

loewenheim Apr 5, 2019

dotlambda Apr 6, 2019

dotlambda Apr 5, 2019

dotlambda Apr 5, 2019

dotlambda Apr 5, 2019

dotlambda commented Apr 5, 2019

gebner commented Apr 5, 2019

gebner Apr 6, 2019

loewenheim Apr 7, 2019

gebner Apr 7, 2019

loewenheim commented Apr 8, 2019

matthiasbeyer commented Apr 8, 2019

dotlambda commented Apr 8, 2019

	# https://github.com/pimutils/vdirsyncer/blob/dcf5f701b7b5c21a8f4e8c80243db3e0baff1313/docs/packaging.rst
	# https://github.com/pimutils/vdirsyncer/blob/0.16.7/docs/packaging.rst

	maintainers = [ loewenheim ];
	maintainers = with maintainers; [ loewenheim ];

vdirsyncerStable: init at 0.16.7 #59010

vdirsyncerStable: init at 0.16.7 #59010

Conversation

loewenheim commented Apr 5, 2019 • edited by dotlambda Loading

Motivation for this change

Things done

dotlambda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

loewenheim commented Apr 5, 2019

dotlambda left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda commented Apr 5, 2019

gebner commented Apr 5, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

loewenheim commented Apr 8, 2019

matthiasbeyer commented Apr 8, 2019

dotlambda commented Apr 8, 2019

loewenheim commented Apr 5, 2019 •

edited by dotlambda

Loading

dotlambda left a comment •

edited

Loading