Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-azure-login: init 1.7.0 #64081

Merged
merged 2 commits into from Jul 4, 2019
Merged

Conversation

NeQuissimus
Copy link
Member

@NeQuissimus NeQuissimus commented Jul 2, 2019

Motivation for this change

Add aws-azure-login to nodePackages.
In order to add the package, I ran generate.sh, which updated all node packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see do the commits not fit the guidelines, do they?

@NeQuissimus
Copy link
Member Author

Rebased

@NeQuissimus NeQuissimus merged commit 3df56e9 into NixOS:master Jul 4, 2019
@NeQuissimus NeQuissimus deleted the aws-azure-login branch July 4, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants