Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redeclipse: init at 1.6.0 #60952

Merged
merged 2 commits into from Jul 2, 2019
Merged

Conversation

lambda-11235
Copy link
Contributor

@lambda-11235 lambda-11235 commented May 4, 2019

Added a package for the FPS Red Eclipse. See https://www.redeclipse.net/.

Motivation for this change

I like the game and think others will as well. I also wanted to learn how to package for Nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg
Copy link
Member

JohnAZoidberg commented May 4, 2019

Can you play the demo maps offline? Doesn't want to load them for me.

could not read demo demos/0.demo

@lambda-11235
Copy link
Contributor Author

lambda-11235 commented May 4, 2019

Can you play the demo maps offline? Doesn't want to load them for me.

Demo maps are recordings of server of old races. I think they have to be setup on servers to actually use them. They are rarely (if ever) used, so I'm a bit fuzzy on the details. But for a first install there won't be any.

Edit: @JohnAZoidberg Setting /demoautoclientsave 1 in the chat causes demos to be recorded properly for me, which how they should work. Can you reproduce?

jtojnar
jtojnar previously requested changes May 6, 2019
pkgs/games/redeclipse/default.nix Outdated Show resolved Hide resolved
pkgs/games/redeclipse/default.nix Outdated Show resolved Hide resolved
pkgs/games/redeclipse/default.nix Outdated Show resolved Hide resolved
@lambda-11235
Copy link
Contributor Author

@jtojnar I've merged your requested changes, but the marker won't go away. Can you check that the changes are there and fix the marker status on your end?

@jtojnar jtojnar dismissed their stale review May 7, 2019 02:21

resolved

pkgs/games/redeclipse/default.nix Outdated Show resolved Hide resolved
pkgs/games/redeclipse/default.nix Outdated Show resolved Hide resolved
pkgs/games/redeclipse/default.nix Outdated Show resolved Hide resolved
@Lassulus
Copy link
Member

Lassulus commented Jul 2, 2019

tested with nix-review, starts, I can edit stuff and play

@Lassulus Lassulus merged commit e706a83 into NixOS:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants