Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/httpd: module cleanup #64151

Merged
merged 3 commits into from Jul 24, 2019
Merged

nixos/httpd: module cleanup #64151

merged 3 commits into from Jul 24, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jul 2, 2019 •
edited

Motivation for this change

Module cleanup:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

aanderse commented Jul 2, 2019 •
edited

@GrahamcOfBorg test haproxy
@GrahamcOfBorg test tomcat
@GrahamcOfBorg test upnp

@aanderse
Copy link
Member Author

aanderse commented Jul 2, 2019

error: timed out waiting for the VM to connect

All tests run fine here... 🤷‍♂️

@aanderse aanderse changed the title Httpd extra subservices nixos/httpd: module cleanup Jul 2, 2019
@aanderse aanderse requested a review from grahamc July 20, 2019 01:29
@aanderse aanderse requested a review from grahamc July 20, 2019 22:37
@aanderse aanderse merged commit 72ef478 into NixOS:master Jul 24, 2019
@aanderse aanderse deleted the httpd-extraSubservices branch July 24, 2019 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbst danbst danbst approved these changes

@copumpkin copumpkin Awaiting requested review from copumpkin

@qknight qknight Awaiting requested review from qknight

@vcunat vcunat Awaiting requested review from vcunat

@infinisil infinisil Awaiting requested review from infinisil

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing appearance of postgresql on brand new system with only httpd running
3 participants
@aanderse @grahamc @danbst