Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kakoune: 2019.01.20 -> 2019.07.01 #64071

Closed
wants to merge 1 commit into from
Closed

Conversation

utdemir
Copy link
Member

@utdemir utdemir commented Jul 1, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

Ping @alyssais

@alyssais
Copy link
Member

alyssais commented Jul 1, 2019

@GrahamcOfBorg build kakoune

@alyssais
Copy link
Member

alyssais commented Jul 1, 2019 via email

@alyssais
Copy link
Member

alyssais commented Jul 2, 2019

Failed to build on Darwin.

@utdemir
Copy link
Member Author

utdemir commented Jul 2, 2019

@alyssais Oh, thanks for the notification. Unfortunately I do not have a Darwin machine to test on, so I'd appreciate some help on the error.

@infinisil
Copy link
Member

For reference, this is the error as reported by the build bot:

file.cc:277:42: error: 'uncaught_exceptions' is unavailable: introduced in macOS 10.12
      : m_fd{fd}, m_exception_count{std::uncaught_exceptions()} {}
                                         ^
/nix/store/5yismw8d67dxddvlcj7i3avkq8gzyb6h-libc++-7.1.0/include/c++/v1/exception:130:63: note: 'uncaught_exceptions' has been explicitly marked unavailable here
_LIBCPP_FUNC_VIS _LIBCPP_AVAILABILITY_UNCAUGHT_EXCEPTIONS int uncaught_exceptions() _NOEXCEPT;
                                                              ^
file.cc:281:54: error: 'uncaught_exceptions' is unavailable: introduced in macOS 10.12
        if (m_pos != 0 and m_exception_count == std::uncaught_exceptions())
                                                     ^
/nix/store/5yismw8d67dxddvlcj7i3avkq8gzyb6h-libc++-7.1.0/include/c++/v1/exception:130:63: note: 'uncaught_exceptions' has been explicitly marked unavailable here
_LIBCPP_FUNC_VIS _LIBCPP_AVAILABILITY_UNCAUGHT_EXCEPTIONS int uncaught_exceptions() _NOEXCEPT;
                                                              ^
2 errors generated.
make: *** [Makefile:104: .file.opt.o] Error 1
builder for '/nix/store/9ank02awy0rg1s5z39v16n5rv7ffg1ai-kakoune-unwrapped-2019.07.01.drv' failed with exit code 2
cannot build derivation '/nix/store/qfv5ndybqihn1rdfspf5zglbm6pmiwss-kakoune-2019.07.01.drv': 1 dependencies couldn't be built
error: build of '/nix/store/qfv5ndybqihn1rdfspf5zglbm6pmiwss-kakoune-2019.07.01.drv' failed

Unfortunately I can't find anything on that in Kakoune's issue tracker

@alyssais alyssais mentioned this pull request Jul 3, 2019
10 tasks
@alyssais
Copy link
Member

alyssais commented Jul 3, 2019

I’m going to close this in favour of #64255. You got there first, but that one has a fix for the Darwin builds.

@alyssais alyssais closed this Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants