Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gildas: 20190601_b -> 20190701_a #64120

Merged
merged 1 commit into from Jul 3, 2019
Merged

gildas: 20190601_b -> 20190701_a #64120

merged 1 commit into from Jul 3, 2019

Conversation

smaret
Copy link
Member

@smaret smaret commented Jul 2, 2019 •
edited by veprbl

Motivation for this change

Update Gildas to the latest upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@smaret smaret mentioned this pull request Jul 2, 2019
Closed
10 tasks
@smaret
Copy link
Member Author

smaret commented Jul 2, 2019 •
edited

OfBorg build on x86_64-linux failed because the compiler went out of memory. I've built the package on a local x86_64-linux (Debian) successfully.

@veprbl veprbl merged commit 3ff069d into NixOS:master Jul 3, 2019
@smaret smaret deleted the gildas-201907a branch July 3, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smaret @veprbl