Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcv-rack: 0.6.2b -> 1.1.3 #63984

Merged
merged 1 commit into from Aug 7, 2019
Merged

vcv-rack: 0.6.2b -> 1.1.3 #63984

merged 1 commit into from Aug 7, 2019

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Jul 1, 2019 •
edited

Motivation for this change

Version bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Moredread
Copy link
Contributor Author

Mhh, it looks like some binary cpre plugins aren't loading/available. Marking this PR WIP for now.

Maybe we should try to build the core plugins ourselfs instead of relaying on the binary version.

@Moredread Moredread changed the title vcv-rack: 0.6.2b -> 1.1.0 (WIP) vcv-rack: 0.6.2b -> 1.1.0 Jul 1, 2019
@Moredread Moredread changed the title (WIP) vcv-rack: 0.6.2b -> 1.1.0 vcv-rack: 0.6.2b -> 1.1.0 Jul 1, 2019
@Moredread
Copy link
Contributor Author

OK, I missed that we need to copy Core.json now so that that plugin is recognized. Users still need to get the Fundamental plugin from the store, but everything else works as normal.

@Moredread Moredread force-pushed the rack branch 2 times, most recently from 0131226 to dc2e186 Compare July 5, 2019 15:39
@Moredread Moredread changed the title vcv-rack: 0.6.2b -> 1.1.0 vcv-rack: 0.6.2b -> 1.1.1 Jul 6, 2019
@mmilata
Copy link
Member

mmilata commented Jul 6, 2019

Seems to be working fine, thanks!

@Moredread
Copy link
Contributor Author

I've added a comment for the glfw patch.

@jpotier
Copy link
Contributor

jpotier commented Jul 17, 2019

Add to my overlay as-is, working fine!

@Moredread Moredread changed the title vcv-rack: 0.6.2b -> 1.1.1 vcv-rack: 0.6.2b -> 1.1.3 Aug 2, 2019
@Moredread
Copy link
Contributor Author

I've updated the PR to 1.1.3.

@Moredread
Copy link
Contributor Author

@jpotier @mmilata Do you want to have a look again? I would be very grateful. :)

@jpotier
Copy link
Contributor

jpotier commented Aug 3, 2019

I have updated this in my overlay verbatim, and it still runs great!

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/35

@mmilata
Copy link
Member

mmilata commented Aug 6, 2019

Builds & runs without problems!

@Lassulus
Copy link
Member

Lassulus commented Aug 7, 2019

tested with nix-review, created an account, added some extra "instruments". everything worked finde

@Lassulus Lassulus merged commit b1bd9fc into NixOS:master Aug 7, 2019
@Moredread Moredread deleted the rack branch August 7, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Moredread @mmilata @jpotier @nixos-discourse @Lassulus