New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extremely low (x1/128) track build/remove cost severely restricts the track conversion feature. #7633
Comments
It looks like the problem would be the cost becoming 0 rather than -1. Line 1776 in 0db31ae
The solution will likely have to be tracking a separate error flag throughout the function. |
Does the same problem with zero-cost conversion failing occur with road and tramway? If so, could you fix those as well (same/similar method to #7634, tracking separate "found_convertible_road" and "found_convertible_tramway" flags in addition to "found_convertible_track")? |
I can't reproduce it with RattRoads at least, I haven't tried with tram tracks though. (This is without the patch in #7634.) Still might be worth making the same change to road building. |
Version of OpenTTD
OpenTTD 20190603-master
Expected result
You should be able to universally convert track no matter what the costs are for building track.
Actual result
When you use BaseCosts 5.0 newGRF to set the "build track" cost multiplier and "remove track" cost multiplier to x1/128, track conversion is no longer universal: Instead, you can convert (electrified) rail to monorail or maglev, and you can convert from monorail to maglev and vice versa. That's it. You can't convert from monorail/maglev to normal railway, nor can you (de)electrify railways.
I think reducing the build track and remove track costs to x1/128 causes some combinations to return 0 as the cost, which the game treats as being invalid, and so those conversions return "No suitable railway track" and are therefore prohibited.
Steps to reproduce
The text was updated successfully, but these errors were encountered: