Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iceshelf: init at unstable-2019-07-03 #64235

Merged
merged 1 commit into from Jul 6, 2019
Merged

iceshelf: init at unstable-2019-07-03 #64235

merged 1 commit into from Jul 6, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jul 3, 2019 •
edited

Motivation for this change

iceshelf: init at unstable-2019-07-03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut mmahut changed the title iceshelf: init at unstable-2019-06-18 iceshelf: init at unstable-2019-07-03 Jul 3, 2019
jonringer
jonringer reviewed Jul 3, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since python2 is nearing end of life, i would use python3.

pythonPackages is aliased to python27.pkgs

pkgs/tools/backup/iceshelf/default.nix Outdated Show resolved Hide resolved
pkgs/tools/backup/iceshelf/default.nix Outdated Show resolved Hide resolved
pkgs/tools/backup/iceshelf/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
@mmahut
Copy link
Member Author

mmahut commented Jul 3, 2019

@jonringer good point, however, if the package works fine with python2, I would prefer to leave it up for the distribution to make that decision. Just because the upstream will stop the support doesn't mean all the distributions will, therefore I don't feel comfortable to force this on python3 unless I have to (I tested it on python3 too tho).

@jonringer
Copy link
Contributor

Just mentioned it because https://github.com/mrworf/iceshelf/wiki/Installing-iceshelf doesn't really mention anything about being tied to a particular version, and I'm disillusioned with python2 and it's all it's quarks

@worldofpeace
Copy link
Contributor

I think it would be better to just use python3.pkgs in the expression.
I don't think we lose anything by using python3 by default since it's just an application.

Eventually we'll have to switch it over anyway.

worldofpeace
worldofpeace suggested changes Jul 6, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just replace all references of pythonPackages and python with python3 and python3.pkgs

@mmahut
Copy link
Member Author

mmahut commented Jul 6, 2019

Thank you, rebased.

worldofpeace
worldofpeace approved these changes Jul 6, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎊

@worldofpeace worldofpeace merged commit 7c2ac5b into NixOS:master Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmahut @jonringer @worldofpeace