Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/programs/shell.nix: don't use unnecessary GNU-specific option #64121

Merged
merged 1 commit into from Jul 31, 2019
Merged

nixos/programs/shell.nix: don't use unnecessary GNU-specific option #64121

merged 1 commit into from Jul 31, 2019

Conversation

tadeokondrak
Copy link
Member

Motivation for this change

I was trying out replacing GNU coreutils with busybox ones, and this caused a long error message on every rebuild. I know that this use-case isn't supported, but it's a small change that doesn't give up any functionality.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danbst
Copy link
Contributor

danbst commented Jul 4, 2019

interesting...

$ [ "$(echo 1000; echo "")" == "1000" ] && echo yes
yes
$ [ "$(echo ""; echo 1000)" == "1000" ] && echo yes

$

Insane bash magic

@worldofpeace worldofpeace merged commit bb4f61f into NixOS:master Jul 31, 2019
@matthewbauer
Copy link
Member

Cherry picked in 500931b

matthewbauer pushed a commit that referenced this pull request Aug 24, 2019
@tadeokondrak @matthewbauer
nixos/programs/shell.nix: don't use unnecessary GNU-specific option
500931b 
(cherry picked from commit fef4dc5)

Fixes #64121
angerman pushed a commit to angerman/nixpkgs that referenced this pull request Sep 2, 2019
@tadeokondrak @angerman
nixos/programs/shell.nix: don't use unnecessary GNU-specific option
e72edac 
(cherry picked from commit fef4dc5)

Fixes NixOS#64121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbst danbst danbst approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tadeokondrak @danbst @matthewbauer @worldofpeace