Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chuck: 1.3.5.2 -> 1.4.0.0 #64018

Merged
merged 1 commit into from Jul 31, 2019
Merged

chuck: 1.3.5.2 -> 1.4.0.0 #64018

merged 1 commit into from Jul 31, 2019

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Jul 1, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested on NixOS with ALSA. I dropped the clang patch because it does not apply, and the problem code has been replaced.

@ndowens @ftrvxmtrx

worldofpeace
worldofpeace suggested changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change meta platforms to unix.

pkgs/applications/audio/chuck/default.nix Outdated Show resolved Hide resolved
@ehmry
Copy link
Contributor Author

ehmry commented Jul 31, 2019

@worldofpeace done.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build chuck

worldofpeace
worldofpeace approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not going to wait for the linux check to pass since I've already tested this.

@worldofpeace worldofpeace merged commit c826ca7 into NixOS:master Jul 31, 2019
@ehmry ehmry deleted the chuck branch July 31, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehmry @worldofpeace